Repository navigation
fix(speculative): add the Muse Glimmer final norm for streaming EAGLE3/DFlash training - #3076
Draft
aniskumar-nv wants to merge 1 commit into
Draft
aniskumar-nv wants to merge 1 commit into
aniskumar-nv wants to merge 1 commit into
Conversation
…3/DFlash training meta-models/Muse-Glimmer-30B nests its text stack as text_config with model_type muse_glimmer_text, which _FINAL_NORM_TYPE_BY_MODEL_TYPE did not list, so FakeBaseModel could not reconstruct the base logits from the streamed pre-norm hidden state. The per-layer sandwich norms of this Gemma-2 derivative carry the (1 + weight) offset but the final norm does not: plain normed * weight reproduces HF hidden_states[-1] at cos=0.999999 (max-abs 0.21, bf16 noise) while the (1 + weight) form gives cos=0.9207 / max-abs 62.7, measured on the released checkpoint. Register both the nested and the text-only model type as plain rmsnorm. Co-Authored-By: Claude Fable 5.1 <[email protected]> Signed-off-by: Anish Kumar <[email protected]>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: Bug fix.
Streaming EAGLE3/DFlash training on
meta-models/Muse-Glimmer-30Bfails because its text stack is nested astext_configwithmodel_type: muse_glimmer_text, which_FINAL_NORM_TYPE_BY_MODEL_TYPEdoes not list, soFakeBaseModelcannot reconstruct the base logits from the streamed pre-norm hidden state.This registers
muse_glimmer_text(andmuse_glimmer, for a text-only checkpoint) as plainrmsnorm. The model is a Gemma-2 derivative whose per-layer sandwich norms carry the(1 + weight)offset, but its final norm does not: on the released checkpoint,normed * weightreproduces HFhidden_states[-1]at cos 0.999999 (max-abs 0.21, bf16 noise), while the(1 + weight)form gives cos 0.9207 / max-abs 62.7. Same pattern as the Gemma 4 entries.Usage
No new flags. Streaming training on this target works once the entry exists.
Testing
test_select_final_norm_typegains both keys.meta-models/Muse-Glimmer-30B(bf16, B300): forward hook on the finalMuseGlimmerRMSNorminput, both candidate forms compared with the module output and withhidden_states[-1].Before your PR is "Ready for review"
CONTRIBUTING.md: N/AAdditional Information
Draft until a Muse Glimmer EAGLE3/DFlash training smoke with this entry has run end to end.
🤖 Generated with Claude Code