Repository navigation
Conversation
BaseOS Kernel ReviewTip ✅ Review passedNo issues found across the reviewed commits. Findings: none 🔍 Review artifacts
📦 Build checks — 🔴 2/4 passed
Note Build reports and debs are retained for 10 days after the PR closes.
Review metadata
This comment is maintained by BaseOS Reviewer and updated when the GitHub watcher publishes a newer review. |
PR Validation ReportPatchscan ✅ No Missing FixesAll cherry-picked commits checked — no missing upstream fixes found. PR Lint
|
|
Are there plans to upstream this patch? |
|
Reply to Boro review. On mt7925 the WM/WA flags don't change routing: mt7925_mcu_fill_message() sets |
Yes. Though I don't know if by me. |
|
Please add this Launchpad link to the PR description:
|
|
I see little reason to carry this as SAUCE without getting MediaTek's Some review findings on the current version:
On the Boro finding: agree with the analysis above; |
84658f0 to
6e67de8
Compare
|
Cleaned up the change (second and third bullets). |
6e67de8 to
6b148d6
Compare
|
Also, wondering, should I add |
fa11997 to
f942d99
Compare
|
After running for a couple of days, the new change seems stable and works. I also have a local |
09b2ca0 to
b94fae5
Compare
… on each link Secondary-link group frames arrive as translated Ethernet frames with no peer station and are rejected by mac80211. The NULL-peer station update configures only the default broadcast WCID, leaving secondary entries at firmware defaults. After each successful station link BSS update, configure that link's broadcast WCID to retain 802.11 headers for station lookup. Signed-off-by: Max Eisenstein <[email protected]>
6b148d6 to
78f6a5a
Compare
Secondary-link group frames arrive as translated Ethernet frames with no peer station and are rejected by mac80211. The NULL-peer station update configures only the default broadcast WCID, leaving secondary entries at firmware defaults.
After each successful station link BSS update, configure that link's broadcast WCID to retain 802.11 headers for station lookup. Expose command-success and error counters. Request device reset recovery on allocation, missing-WCID or MCU programming failures, covering station callbacks that discard the helper's return value.
LP: https://bugs.launchpad.net/bugs/2172838