Skip to content

[26.04_linux-nvidia-bos] NVIDIA: VR: SAUCE: arm64: topology: Revert Olympus SMT quirk - #721

Closed
arighi wants to merge 1 commit into
NVIDIA:26.04_linux-nvidia-bosfrom
arighi:26.04_linux-nvidia-bos-drop-olympus-smt-quirk
Closed

arighi wants to merge 1 commit into
NVIDIA:26.04_linux-nvidia-bosfrom
arighi:26.04_linux-nvidia-bos-drop-olympus-smt-quirk

Conversation

@arighi

@arighi arighi commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

The upstream SMT packing override and idle sibling selection backports replace the Olympus-specific topology quirk. The override is enabled by default on arm64, preserving SMT sibling preference without CPU model detection.

The retained quirk unconditionally sets SD_ASYM_PACKING on Olympus, so sched_smt_asym_packing=off cannot disable the preference. Remove the custom topology and its initialization hook so the boot option controls the override. Also remove the arm64 CPU priority override to restore the upstream default preference for lower-numbered logical CPUs.

LP: https://bugs.launchpad.net/bugs/2174992

@nirmoy nirmoy added the help wanted Extra attention is needed label Nov 19, 2026
@nirmoy

nirmoy commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

BaseOS Kernel Review

Tip

✅ Review passed

No issues found across the reviewed commits.

Findings: none

🔍 Review artifacts

📦 Build checks — 🔴 2/4 passed

Note

Build reports and debs are retained for 10 days after the PR closes.

  • 🟢 PR Illustrated: ready
Review metadata
  • Reviewed head: a3d2a98d6efb
  • Overall status: build partially successful
  • Build checks: 2/4 passed

This comment is maintained by BaseOS Reviewer and updated when the GitHub watcher publishes a newer review.

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

PR Validation Report

Patchscan ✅ No Missing Fixes

All cherry-picked commits checked — no missing upstream fixes found.

PR Lint ✅ All checks passed

Details
Checking 1 commits...

Cherry-pick digest:
┌──────────────┬──────────────────────────────────────────────────────────────────┬────────────┬─────────┬───────────────────────────┐
│ Local        │ Referenced upstream / Patch subject                              │ Patch-ID   │ Subject │ SoB chain                 │
├──────────────┼──────────────────────────────────────────────────────────────────┼────────────┼─────────┼───────────────────────────┤
│ a3d2a98d6efb │ [Revert] arm64: topology: prefer pe0 on nvidia olympus smt cores │ N/A        │ N/A     │ arighi                    │
└──────────────┴──────────────────────────────────────────────────────────────────┴────────────┴─────────┴───────────────────────────┘

Lint: all checks passed.

@nvmochs

nvmochs commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

@arighi Isn't this essentially a revert of "b81846eab0da NVIDIA: VR: SAUCE: arm64: topology: Prefer PE0 on NVIDIA Olympus SMT cores" ? If so, should this be a revert commit?

@arighi

arighi commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator Author

@nvmochs yes, this exactly reverts that commit, I'll make this more explicit in the commit message and subject.

…pus SMT cores"

BugLink: https://bugs.launchpad.net/bugs/2174992

This reverts commit b81846e.

The upstream SMT packing override and idle sibling selection backports
replace the Olympus-specific topology quirk. The override is enabled by
default on arm64, preserving SMT sibling preference without CPU model
detection.

The retained quirk unconditionally sets SD_ASYM_PACKING on Olympus, so
sched_smt_asym_packing=off cannot disable the preference. Remove the
custom topology and its initialization hook so the boot option controls
the override. Also remove the arm64 CPU priority override to restore the
upstream default preference for lower-numbered logical CPUs.

Signed-off-by: Andrea Righi <[email protected]>
@arighi
arighi force-pushed the 26.04_linux-nvidia-bos-drop-olympus-smt-quirk branch from 1539dea to a3d2a98 Compare November 19, 2026 16:58
@nvmochs

nvmochs commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

Thanks Andrea!

No further issues or concerns from me.

Acked-by: Matthew R. Ochs <[email protected]>

@jamieNguyenNVIDIA

Copy link
Copy Markdown
Collaborator

Acked-by: Jamie Nguyen <[email protected]>

@nirmoy nirmoy added has_2_acks and removed help wanted Extra attention is needed labels Nov 19, 2026
@clsotog

clsotog commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

Acked-by: Carol L Soto <[email protected]>

@nvmochs

nvmochs commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

Merged, closing PR.

7cc6a59c88e8 (nresolute/nvidia-bos-next) Revert "NVIDIA: VR: SAUCE: arm64: topology: Prefer PE0 on NVIDIA Olympus SMT cores"

@nvmochs nvmochs closed this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants