Repository navigation
Conversation
BaseOS Kernel ReviewTip ✅ Review passedNo issues found across the reviewed commits. Findings: none 🔍 Review artifacts
📦 Build checks — 🔴 2/4 passed
Note Build reports and debs are retained for 10 days after the PR closes.
Review metadata
This comment is maintained by BaseOS Reviewer and updated when the GitHub watcher publishes a newer review. |
PR Validation ReportPatchscan ✅ No Missing FixesAll cherry-picked commits checked — no missing upstream fixes found. PR Lint ✅ All checks passedDetailsChecking 1 commits... Cherry-pick digest: ┌──────────────┬──────────────────────────────────────────────────────────────────┬────────────┬─────────┬───────────────────────────┐ │ Local │ Referenced upstream / Patch subject │ Patch-ID │ Subject │ SoB chain │ ├──────────────┼──────────────────────────────────────────────────────────────────┼────────────┼─────────┼───────────────────────────┤ │ a3d2a98d6efb │ [Revert] arm64: topology: prefer pe0 on nvidia olympus smt cores │ N/A │ N/A │ arighi │ └──────────────┴──────────────────────────────────────────────────────────────────┴────────────┴─────────┴───────────────────────────┘ Lint: all checks passed. |
|
@arighi Isn't this essentially a revert of "b81846eab0da NVIDIA: VR: SAUCE: arm64: topology: Prefer PE0 on NVIDIA Olympus SMT cores" ? If so, should this be a revert commit? |
|
@nvmochs yes, this exactly reverts that commit, I'll make this more explicit in the commit message and subject. |
…pus SMT cores" BugLink: https://bugs.launchpad.net/bugs/2174992 This reverts commit b81846e. The upstream SMT packing override and idle sibling selection backports replace the Olympus-specific topology quirk. The override is enabled by default on arm64, preserving SMT sibling preference without CPU model detection. The retained quirk unconditionally sets SD_ASYM_PACKING on Olympus, so sched_smt_asym_packing=off cannot disable the preference. Remove the custom topology and its initialization hook so the boot option controls the override. Also remove the arm64 CPU priority override to restore the upstream default preference for lower-numbered logical CPUs. Signed-off-by: Andrea Righi <[email protected]>
1539dea to
a3d2a98
Compare
|
Thanks Andrea! No further issues or concerns from me.
|
|
|
|
|
|
Merged, closing PR. |
The upstream SMT packing override and idle sibling selection backports replace the Olympus-specific topology quirk. The override is enabled by default on arm64, preserving SMT sibling preference without CPU model detection.
The retained quirk unconditionally sets SD_ASYM_PACKING on Olympus, so sched_smt_asym_packing=off cannot disable the preference. Remove the custom topology and its initialization hook so the boot option controls the override. Also remove the arm64 CPU priority override to restore the upstream default preference for lower-numbered logical CPUs.
LP: https://bugs.launchpad.net/bugs/2174992