Skip to content

[26.04_linux-nvidia] fs/resctrl: Report unknown schemata domains - #722

Draft
nirmoy wants to merge 1 commit into
NVIDIA:26.04_linux-nvidiafrom
nirmoy:codex/nvbug-7080254-7.0-lts
Draft

nirmoy wants to merge 1 commit into
NVIDIA:26.04_linux-nvidiafrom
nirmoy:codex/nvbug-7080254-7.0-lts

Conversation

@nirmoy

@nirmoy nirmoy commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

A schemata write naming an unknown domain returns EINVAL, but last_cmd_status reports ok because parse_line() does not record a diagnostic. Report the invalid domain ID while preserving the error return and staged-configuration cleanup.

A schemata write to an unknown domain returns -EINVAL without setting
last_cmd_status. The status buffer is cleared before parsing, so reading
last_cmd_status after the failed write incorrectly reports "ok".

Report the invalid domain before returning -EINVAL, matching the existing
I/O allocation parser diagnostic.

Fixes: c377dcf ("x86/intel_rdt: Add diagnostics when writing the schemata file")
Signed-off-by: Nirmoy Das <[email protected]>
(backported from https://lore.kernel.org/r/[email protected])
Signed-off-by: Nirmoy Das <[email protected]>
@nirmoy

nirmoy commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator Author

BaseOS Kernel Review

Tip

✅ Review passed

No issues found across the reviewed commits.

Findings: none

🔍 Review artifacts

📦 Build checks — 🟢 4/4 passed

Note

Build reports and debs are retained for 10 days after the PR closes.

  • 🟢 PR Illustrated: ready
Review metadata
  • Reviewed head: 0c9d12415fce
  • Overall status: kernel validation regression
  • Build checks: 4/4 passed

This comment is maintained by BaseOS Reviewer and updated when the GitHub watcher publishes a newer review.

@github-actions

Copy link
Copy Markdown
Contributor

PR Validation Report

Patchscan ✅ No Missing Fixes

All cherry-picked commits checked — no missing upstream fixes found.

PR Lint ❌ Errors found

Details
Checking 1 commits...

Cherry-pick digest:
┌──────────────┬──────────────────────────────────────────────────────────────────┬────────────┬─────────┬───────────────────────────┐
│ Local        │ Referenced upstream / Patch subject                              │ Patch-ID   │ Subject │ SoB chain                 │
├──────────────┼──────────────────────────────────────────────────────────────────┼────────────┼─────────┼───────────────────────────┤
│ 0c9d12415fce │ fs/resctrl: report unknown schemata domains                      │ match      │ found   │ ok, backporter: nirmoyd   │
└──────────────┴──────────────────────────────────────────────────────────────────┴────────────┴─────────┴───────────────────────────┘

Lint: all checks passed.

PR metadata:
E: PR targets 26.04_linux-nvidia but body has no https://bugs.launchpad.net/... link

@nvmochs

nvmochs commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

Confirmed this is the same fix as in #709

Acked-by: Matthew R. Ochs <[email protected]>

@jamieNguyenNVIDIA

Copy link
Copy Markdown
Collaborator

Acked-by: Jamie Nguyen <[email protected]>

@clsotog

clsotog commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

Acked-by: Carol L Soto <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants