Repository navigation
Conversation
A schemata write to an unknown domain returns -EINVAL without setting last_cmd_status. The status buffer is cleared before parsing, so reading last_cmd_status after the failed write incorrectly reports "ok". Report the invalid domain before returning -EINVAL, matching the existing I/O allocation parser diagnostic. Fixes: c377dcf ("x86/intel_rdt: Add diagnostics when writing the schemata file") Signed-off-by: Nirmoy Das <[email protected]> (backported from https://lore.kernel.org/r/[email protected]) Signed-off-by: Nirmoy Das <[email protected]>
Collaborator
Author
BaseOS Kernel ReviewTip ✅ Review passedNo issues found across the reviewed commits. Findings: none 🔍 Review artifacts
📦 Build checks — 🟢 4/4 passed
Note Build reports and debs are retained for 10 days after the PR closes.
Review metadata
This comment is maintained by BaseOS Reviewer and updated when the GitHub watcher publishes a newer review. |
Contributor
PR Validation ReportPatchscan ✅ No Missing FixesAll cherry-picked commits checked — no missing upstream fixes found. PR Lint ❌ Errors foundDetailsChecking 1 commits... Cherry-pick digest: ┌──────────────┬──────────────────────────────────────────────────────────────────┬────────────┬─────────┬───────────────────────────┐ │ Local │ Referenced upstream / Patch subject │ Patch-ID │ Subject │ SoB chain │ ├──────────────┼──────────────────────────────────────────────────────────────────┼────────────┼─────────┼───────────────────────────┤ │ 0c9d12415fce │ fs/resctrl: report unknown schemata domains │ match │ found │ ok, backporter: nirmoyd │ └──────────────┴──────────────────────────────────────────────────────────────────┴────────────┴─────────┴───────────────────────────┘ Lint: all checks passed. PR metadata: E: PR targets 26.04_linux-nvidia but body has no https://bugs.launchpad.net/... link |
Collaborator
|
Confirmed this is the same fix as in #709
|
Collaborator
|
|
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A schemata write naming an unknown domain returns
EINVAL, butlast_cmd_statusreportsokbecauseparse_line()does not record a diagnostic. Report the invalid domain ID while preserving the error return and staged-configuration cleanup.