Repository navigation
Conversation
A schemata write to an unknown domain returns -EINVAL without setting last_cmd_status. The status buffer is cleared before parsing, so reading last_cmd_status after the failed write incorrectly reports "ok". Report the invalid domain before returning -EINVAL, matching the existing I/O allocation parser diagnostic. Fixes: c377dcf ("x86/intel_rdt: Add diagnostics when writing the schemata file") Signed-off-by: Nirmoy Das <[email protected]> (backported from https://lore.kernel.org/r/[email protected]) Signed-off-by: Nirmoy Das <[email protected]>
BaseOS Kernel ReviewTip ✅ Review passedNo issues found across the reviewed commits. Findings: none 🔍 Review artifacts
📦 Build checks — 🟢 4/4 passed
Install the PR kernel with APTPublished for reviewed head curl -fsS https://baseos-reviewer-66d7b9.gitlab-master-pages.nvidia.com/install.sh | bash -s -- install pr-723Manual installationManual setup · signing fingerprint Manual commands for Ubuntu 26.04 Resolute / arm64, on the NVIDIA network: (
set -euo pipefail
work=$(mktemp -d)
trap 'rm -rf -- "$work"' EXIT
curl -qfsS --proto '=https' -o "$work/archive-keyring.gpg" https://baseos-reviewer-66d7b9.gitlab-master-pages.nvidia.com/archive-keyring.gpg
curl -qfsS --proto '=https' -o "$work/baseos-internal-tools.crt" https://baseos-reviewer-66d7b9.gitlab-master-pages.nvidia.com/baseos-internal-tools.crt
sudo install -d -m 0755 /etc/apt/keyrings
sudo install -m 0644 "$work/archive-keyring.gpg" /usr/share/keyrings/baseos-pr-kernels.gpg
sudo install -m 0644 "$work/baseos-internal-tools.crt" /etc/apt/keyrings/baseos-pr-https.crt
printf '%s\n' \
'Acquire::https::baseos-internal-tools.nvidia.com::CaInfo "/etc/apt/keyrings/baseos-pr-https.crt";' \
'Acquire::https::baseos-internal-tools.nvidia.com::Verify-Peer "true";' \
'Acquire::https::baseos-internal-tools.nvidia.com::Verify-Host "true";' | \
sudo tee /etc/apt/apt.conf.d/90baseos-pr-kernels >/dev/null
printf '%s\n' 'deb [arch=arm64 signed-by=/usr/share/keyrings/baseos-pr-kernels.gpg] https://baseos-internal-tools.nvidia.com:4001/reviews/apt/NVIDIA/NV-Kernels/723/resolute/arm64 resolute main' | \
sudo tee /etc/apt/sources.list.d/nv-kernels-pr723.list >/dev/null
sudo apt update --error-on=any
sudo apt install --no-remove nv-kernels-pr-723
)For Ubuntu 24.04 Noble / amd64, use the same flow with this source line: The repository remains configured. Later Note Build reports and debs are retained for 10 days after the PR closes.
Review metadata
This comment is maintained by BaseOS Reviewer and updated when the GitHub watcher publishes a newer review. |
PR Validation ReportPatchscan ✅ No Missing FixesAll cherry-picked commits checked — no missing upstream fixes found. PR Lint ❌ Errors foundDetailsChecking 1 commits... Cherry-pick digest: ┌──────────────┬──────────────────────────────────────────────────────────────────┬────────────┬─────────┬───────────────────────────┐ │ Local │ Referenced upstream / Patch subject │ Patch-ID │ Subject │ SoB chain │ ├──────────────┼──────────────────────────────────────────────────────────────────┼────────────┼─────────┼───────────────────────────┤ │ dfa4b4058577 │ fs/resctrl: report unknown schemata domains │ match │ found │ ok, backporter: nirmoyd │ └──────────────┴──────────────────────────────────────────────────────────────────┴────────────┴─────────┴───────────────────────────┘ Lint: all checks passed. PR metadata: E: PR targets 26.04_linux-nvidia-7.3-next but body has no https://bugs.launchpad.net/... link |
|
Confirmed this is the same fix as in #709
|
|
|
|
|
A schemata write naming an unknown domain returns
EINVAL, butlast_cmd_statusreportsokbecauseparse_line()does not record a diagnostic. Report the invalid domain ID while preserving the error return and staged-configuration cleanup.