Skip to content

test(cuda.core): gate the NVRTC option tests on the cuda-bindings version #3335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andy-Jost merged 2 commits into from
Nov 3, 2026
Merged

test(cuda.core): gate the NVRTC option tests on the cuda-bindings version #3335

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fdc010
test(cuda.core): gate the NVRTC option tests on the cuda-bindings ver…
Andy-Jost Nov 2, 2026
69ea302
Merge remote-tracking branch 'origin/main' into ajost/nvrtc-option-te…
Andy-Jost Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 17 additions & 28 deletions cuda_core/tests/test_program.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
from cuda.core._module import Kernel, ObjectCode
from cuda.core._program import Program, ProgramOptions
from cuda.core._utils.cuda_utils import CUDAError, handle_return, nvrtc
from cuda.core._utils.version import binding_version
from cuda.core.typing import CompilerBackendType, PCHStatusType
from cuda.pathfinder import DynamicLibNotFoundError

Expand Down Expand Up @@ -68,6 +69,17 @@ def _get_nvrtc_version_for_tests():
reason="use_bundled_headers requires NVRTC >= 13.3",
)

# The option tests check that cuda.core encodes each ProgramOptions field as a
# flag that NVRTC accepts. One pass on a current NVRTC proves the encoding, and
# an older NVRTC rejects flags that it predates. Run them only when NVRTC is at
# least the CUDA version of the installed cuda-bindings, so that the gate moves
# with cuda-bindings releases and needs no per-option version table.
_bindings_major, _bindings_minor, _ = binding_version()
nvrtc_at_bindings_version = pytest.mark.skipif(
(_get_nvrtc_version_for_tests() or 0) < _bindings_major * 1000 + _bindings_minor * 100,
reason=f"NVRTC option tests require NVRTC >= {_bindings_major}.{_bindings_minor} (the cuda-bindings version)",
)


def _has_check_nvvm_compiler_options():
try:
Expand Down Expand Up @@ -211,13 +223,7 @@ def ptx_code_object():
),
ProgramOptions(frandom_seed="12345"),
ProgramOptions(ofast_compile="min"),
pytest.param(
ProgramOptions(pch=True),
marks=pytest.mark.skipif(
(_get_nvrtc_version_for_tests() or 0) < 12800,
reason="PCH requires NVRTC >= 12.8",
),
),
ProgramOptions(pch=True),
# TODO: pch_dir requires actual PCH directory to exist - needs integration test
# pytest.param(
# ProgramOptions(pch_dir="/tmp/pch"),
Expand All @@ -226,29 +232,12 @@ def ptx_code_object():
# reason="PCH requires NVRTC >= 12.8",
# ),
# ),
pytest.param(
ProgramOptions(pch_verbose=True),
marks=pytest.mark.skipif(
(_get_nvrtc_version_for_tests() or 0) < 12800,
reason="PCH requires NVRTC >= 12.8",
),
),
pytest.param(
ProgramOptions(pch_messages=False),
marks=pytest.mark.skipif(
(_get_nvrtc_version_for_tests() or 0) < 12800,
reason="PCH requires NVRTC >= 12.8",
),
),
pytest.param(
ProgramOptions(instantiate_templates_in_pch=True),
marks=pytest.mark.skipif(
(_get_nvrtc_version_for_tests() or 0) < 12800,
reason="PCH requires NVRTC >= 12.8",
),
),
ProgramOptions(pch_verbose=True),
ProgramOptions(pch_messages=False),
ProgramOptions(instantiate_templates_in_pch=True),
],
)
@nvrtc_at_bindings_version

@coderabbitai coderabbitai Bot Nov 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor · Functional Correctness · Quick win

important: Gate only unsupported option cases.

With cuda-bindings 13.4 and NVRTC 13.3, this skips every parameter, including ftz, which NVRTC 13.3 supports. (docs.nvidia.com) This removes option coverage from supported mixed-version environments. Apply version gates to the affected parameters instead.

As per path instructions: “skip only for genuine setup or feature-unavailable conditions.”

Source: Path instructions

def test_cpp_program_with_various_options(init_cuda, options):
code = 'extern "C" __global__ void my_kernel() {}'
program = Program(code, "c++", options)
Expand Down
Loading