Repository navigation
docs(model-workflows): align cache file lists and note GPU smoke pre-pull - #1440
Merged
Merged
Conversation
…pull - vllm-quickstart: fix 'verified on' date phrasing - Explain why serve (3 files) and fine-tune readiness (adds tokenizer_config.json) differ; note it in serve-model, shared-cache and finetune-readiness - Document that --gpu-smoke's 5s scheduler window requires a pre-pulled image - Comment that gpu_count() fails closed on unexpected Slurm output Signed-off-by: Doug Holt <[email protected]>
michael-balint
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up docs/comment fixes from review notes on #1423 and #1439. No behavior change.
tokenizer_config.json(noted in vllm-quickstart, serve-model skill, shared-cache and finetune-readiness).--gpu-smoke: document that the 5s scheduler window is too short for an image pull, so pre-pull the pinned image (finetune-readiness, finetune-model skill).gpu_count(): comment that it fails closed if Slurm TRES output changes.Tests:
pytest scripts/validation/tests197 passed, 7 skipped.