Repository navigation
fix(k8s): show the logs of every GPU test pod in verify_gpu.sh - #1443
Merged
Merged
Conversation
The loop that prints the test pod logs counted with $i but indexed the pod array with $k, which is never set. The index was always 0, so the script printed the log of the first completed pod once per GPU and never showed the other pods. Iterate over the completed pods instead, and add a regression case to tests/verify-gpu/test_verify_gpu.py. Co-Authored-By: Claude Fable 5.2 <[email protected]> Signed-off-by: Dezhen Lu <[email protected]>
michael-balint
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/k8s/verify_gpu.shprints the logs of the test pods so thenvidia-smioutput of each GPU can be checked. The loop counts with$ibut indexes the pod array with$k, which is never set. The index is always 0, so the script prints the first completed pod's log once per GPU and never shows the others.This PR iterates over the completed pods instead. The pod-count checks and exit codes after the loop are unchanged.
Testing
test_logs_are_read_once_from_every_completed_podintests/verify-gpu/test_verify_gpu.py(stubkubectl, as in the existing cases). Onmaster@4eb47c33it fails for 3 GPUs with['cluster-gpu-tests-0', 'cluster-gpu-tests-0', 'cluster-gpu-tests-0']; with this change all 3 tests in the file pass (python3 tests/verify-gpu/test_verify_gpu.py). Run on x86_64 Linux, bash 5.2.21, Python 3.12.3.bash -n scripts/k8s/verify_gpu.shandgit diff --checkpass.AI disclosure: found and drafted with an AI coding assistant (Claude Code, claude-fable-5-2), including the loop change, the new test case and this description; the test was run as described above.
🤖 Generated with Claude Code