Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions deployments/gpu-operator/templates/validations.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,8 @@
{{- if and (hasKey .Values.operator "replicaCount") (lt (int .Values.operator.replicaCount) 1) }}
{{- fail "operator.replicaCount must be at least 1" }}
{{- end }}

{{- $pdb := .Values.operator.podDisruptionBudget | default dict }}
{{- if and (dig "enabled" false $pdb) (le (int .Values.operator.replicaCount) 1) }}
{{- fail "operator.podDisruptionBudget.enabled=true requires operator.replicaCount to be at least 2" }}
{{- end }}
Comment on lines +36 to +39

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Untested explicit PDB rejection

Removing this guard leaves TestOperatorHighAvailability and TestOperatorRejectsInvalidReplicaCount passing; neither explicitly enables the PDB with one replica. The testing conventions require a regression test that fails without the fix.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

9 changes: 4 additions & 5 deletions deployments/gpu-operator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,10 @@ operator:
values: [""]
podAntiAffinity:
enabled: true
podDisruptionBudget:
# Created when operator.replicaCount > 1.
# If only one node can run operator pods, this budget can block draining that node.
# Set operator.replicaCount to 1 or disable this podDisruptionBudget to allow draining.
enabled: true
# Created when operator.replicaCount > 1.
# If only one node can run operator pods, this budget can block draining that node.
# Set operator.replicaCount to 1 or disable this podDisruptionBudget to allow draining.
podDisruptionBudget: {}
Comment thread
rajathagasthya marked this conversation as resolved.
Resolved
logging:
# Zap time encoding (one of 'epoch', 'millis', 'nano', 'iso8601', 'rfc3339' or 'rfc3339nano')
timeEncoding: epoch
Expand Down
Loading