Repository navigation
fix(push): an approval push reaches owner devices only - #915
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
A desktop prompt's content-free push also reaches devices marked for computer use. A store that cannot name owners sends no approval push. Three tests that used ordinary devices or fakes without the new store method updated on purpose. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
OAraLabs
marked this pull request as ready for review
November 12, 2026 15:54
Owner
Author
|
Independent review: nothing medium or above. Low 1 fixed (three queries per push, not one per device). Lows left for the backlog: a device held after it was marked for computer use still gets the content-free desktop push, and there is no test for a revoked marked device or a raising store (the bus survives through |
OAraLabs
marked this pull request as draft
November 12, 2026 19:57
OAraLabs
marked this pull request as ready for review
November 12, 2026 21:39
…revoked marked device and a raising store From the second review of this PR. Co-Authored-By: Claude Opus 5.5 <[email protected]>
…o-owner-devices # Conflicts: # CHANGELOG.md
OAraLabs
enabled auto-merge (squash)
November 13, 2026 17:44
…o-owner-devices # Conflicts: # CHANGELOG.md
…o-owner-devices # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An approval push carries the tool name and the first line of the request's description. It went to every device with a push registration, scoped devices included. A scoped device cannot approve anything but a desktop prompt.
Now
Where:
DeviceStore.approval_push_targets(desktop=...), andPushDispatcher._approval_targets.Tests: red first, in
tests/test_approval_push_owner_only.py. Three existing tests changed on purpose: they used ordinary devices or fakes that lack the new store method.Local Mac suite: 15,917 passed, 0 failed (
test_generated_referenceandtest_gate_manifestdeselected: they fail only in a worktree). Ruff, the mypy gate and pip-audit are clean.This conflicts trivially with drafts #912, #913 and #914 (the same two loops in
_push_approval). Whichever merges second rebases.🤖 Generated with Claude Code