Skip to content

fix(push): an approval push reaches owner devices only - #915

Merged
OAraLabs merged 7 commits into
mainfrom
fix/approval-pushes-to-owner-devices
Nov 15, 2026
Merged

OAraLabs merged 7 commits into
mainfrom
fix/approval-pushes-to-owner-devices

Conversation

@OAraLabs

@OAraLabs OAraLabs commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

An approval push carries the tool name and the first line of the request's description. It went to every device with a push registration, scoped devices included. A scoped device cannot approve anything but a desktop prompt.

Now

  • An ordinary approval push goes to live owner devices only.
  • A desktop prompt's push (no tool, no description, no content) goes to owner devices and to devices marked for computer use, the ones that may answer it.
  • A device store that cannot name owner devices sends no approval push at all.

Where: DeviceStore.approval_push_targets(desktop=...), and PushDispatcher._approval_targets.

Tests: red first, in tests/test_approval_push_owner_only.py. Three existing tests changed on purpose: they used ordinary devices or fakes that lack the new store method.

Local Mac suite: 15,917 passed, 0 failed (test_generated_reference and test_gate_manifest deselected: they fail only in a worktree). Ruff, the mypy gate and pip-audit are clean.

This conflicts trivially with drafts #912, #913 and #914 (the same two loops in _push_approval). Whichever merges second rebases.

🤖 Generated with Claude Code

OAraLabs and others added 3 commits November 12, 2026 10:37
A desktop prompt's content-free push also reaches devices marked for computer
use. A store that cannot name owners sends no approval push. Three tests that
used ordinary devices or fakes without the new store method updated on purpose.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@OAraLabs
OAraLabs marked this pull request as ready for review November 12, 2026 15:54
@OAraLabs

OAraLabs commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner Author

Independent review: nothing medium or above. Low 1 fixed (three queries per push, not one per device). Lows left for the backlog: a device held after it was marked for computer use still gets the content-free desktop push, and there is no test for a revoked marked device or a raising store (the bus survives through on_signal's handler).

OAraLabs and others added 2 commits November 13, 2026 12:44
…revoked marked device and a raising store

From the second review of this PR.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@OAraLabs
OAraLabs enabled auto-merge (squash) November 13, 2026 17:44
@OAraLabs
OAraLabs merged commit 4fa03e8 into main Nov 15, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant