Repository navigation
#15063: Histogram: Zoom all when data is filtered by 3D view visibility - #15064
Merged
Merged
Conversation
kriben
reviewed
Oct 28, 2026
kriben
reviewed
Oct 28, 2026
kriben
left a comment
Collaborator
There was a problem hiding this comment.
Automated review (open-code-review, delegate mode). Reviewed 7/7 files, 0 skipped (100% coverage).
No critical or high-severity issues. These were checked and look fine:
- Removing the
RimHistogramPlot.hinclude is safe:RimHistogramDataSource.halready includes it. initAfterInsert()re-runsinitAfterRead()on the curve subtree. All of those (curve, grid statistics data source,RimEclipseResultDefinition,RimPlotCurveAppearance) are idempotent, and re-connecting signals does nothing.- Signal order is correct:
dataSourceChangedis sent beforezoomAllRequested.
Findings: 2 medium, 3 low (see inline comments). Low: there are no tests for the paste path. A small test that copies a curve and checks that m_property has an eclipse case set after initAfterInsert() would guard against regressions.
Zoom all when the cell filter view is changed or when the visibility in the 3D view is updated, as the visible cells can have a very different value range than the full grid.
Re-run initAfterRead() after resolving references of a pasted curve, and set the axis scale of the destination plot from the binning mode.
magnesj
force-pushed
the
histogram-zoom-all-3d-filter
branch
from
October 28, 2026 13:15
c890d7e to
d82b0ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15063
When a grid statistics histogram is filtered by 3D view visibility, zoom all in the plot when the filter view is changed or when the cell visibility in the 3D view is updated.
RimHistogramDataSourcegets a newzoomAllRequestedsignalRimGridStatisticsHistogramDataSourcesends it after updating data for filter changes, and no longer depends onRimHistogramPlotRimHistogramCurvehandles the signal and callszoomAll()on its plotCopy/paste of a histogram curve:
initAfterRead()is re-run after references of a pasted curve are resolved, so the 3D view visibility filter is restoredRimHistogramCurve::updateAxisScaleFromBinningMode())