Skip to content

Use simulated vectors instead of history vectors in correlation report plots - #15071

Merged
magnesj merged 3 commits into
devfrom
minor-fixes
Oct 28, 2026
Merged

magnesj merged 3 commits into
devfrom
minor-fixes

Conversation

@magnesj

@magnesj magnesj commented Oct 28, 2026 •

Copy link
Copy Markdown
Member
  • Correlation report plots no longer include history vectors. If a history vector such as WOPRH is requested, the report is created for the simulated vector (WOPR) instead.
  • The RFT correlation report uses the depth type and unit from the source plot.
  • The Curve Appearance panel, toolbar button and global appearance settings are hidden behind the curve-appearance experimental feature. The keyword is a shared constant, RiaExperimentalFeatures::curveAppearanceKeyword.

@magnesj
magnesj requested a review from kriben October 28, 2026 13:41
@magnesj
magnesj marked this pull request as ready for review October 28, 2026 13:41
@magnesj magnesj self-assigned this Oct 28, 2026

@kriben kriben left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review (open-code-review delegate mode). 6/6 files reviewed, no critical or high-severity issues. 1 medium and 3 low findings are in the inline comments.

Looks fine:

  • Null checks for m_curveStyleRulesView are in place at all three places that use it.
  • nativeVectorNames({x}).front() is safe because one input always gives exactly one output.
  • The RFT depth type is limited to MD/TVD, which matches calculateValueOptions. setDepthUnit runs after applyDepthTypeToSubPlots, and the depth-range conversion uses m_wellRftPlot->depthUnit(), so the unit carries over correctly.

Comment thread ApplicationLibCode/ProjectDataModel/Summary/RimSummaryMultiPlot.cpp
Comment thread ApplicationLibCode/ProjectDataModel/Summary/RimSummaryMultiPlot.cpp
@magnesj
magnesj merged commit d8a63a5 into dev Oct 28, 2026
19 checks passed
@magnesj
magnesj deleted the minor-fixes branch October 28, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants