Repository navigation
Use simulated vectors instead of history vectors in correlation report plots - #15071
Merged
Merged
Conversation
kriben
reviewed
Oct 28, 2026
kriben
left a comment
Collaborator
There was a problem hiding this comment.
Automated review (open-code-review delegate mode). 6/6 files reviewed, no critical or high-severity issues. 1 medium and 3 low findings are in the inline comments.
Looks fine:
- Null checks for
m_curveStyleRulesVieware in place at all three places that use it. nativeVectorNames({x}).front()is safe because one input always gives exactly one output.- The RFT depth type is limited to MD/TVD, which matches
calculateValueOptions.setDepthUnitruns afterapplyDepthTypeToSubPlots, and the depth-range conversion usesm_wellRftPlot->depthUnit(), so the unit carries over correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
curve-appearanceexperimental feature. The keyword is a shared constant,RiaExperimentalFeatures::curveAppearanceKeyword.