Repository navigation
Conversation
6 tasks done
superwhiskers
requested changes
Oct 12, 2026
superwhiskers
left a comment
Collaborator
There was a problem hiding this comment.
i've run the test locally, it passes. this is a significant improvement over the previous implementation ergonomically, so i think it's ready to merge once these comments are addressed
Co-authored-by: superwhiskers <[email protected]>
Collaborator
Author
|
@superwhiskers Thank you for the suggestions I think this model is very clean, now. one of the cleaner implementations, too Notice that the target branch is #566, not develop! That is intended to merge first since I used it here |
superwhiskers
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Templates
Ieeeston its notch order, derived from the notch coefficients, so each order has only its own states and a branch-free residual.Depends on #566. Supersedes #460.
Proposed changes
Ieeest<ScalarT, IdxT, order>andIeeestFactory, which derives the order fromA1–A4.ParameterReaderand check them withConfigurationChecks.VariableMonitoraccept models with extra template parameters.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
Zero lag time constants are now raised to 1 ms instead of bypassed, so that time constants are treated identically for all models. All validation cases containing IEEEST still pass. We could apply this model's approach in the future to the others to resolve any issues time constant might be contributing to #463
@superwhiskers @nkoukpaizan @pelesh I have consolidated all past reviewer comments when considering this final implementation for IEEEST, so your feedback was much appreciated in the superseded PRs.