Skip to content

Computed twig encryption fix - #380

Merged
stankut merged 2 commits into
developfrom
f/computed-twig-encryption
Nov 2, 2026
Merged

stankut merged 2 commits into
developfrom
f/computed-twig-encryption

Conversation

@stankut

@stankut stankut commented Oct 23, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@jekuaitk jekuaitk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the full overview of the necessity of this, but as long as it is tested im ok with it!

@jekuaitk

Copy link
Copy Markdown
Contributor

Turns out it is also needed for checkboxes since it's value is either the integer 0 or 1.

@stankut

stankut commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator Author

@jekuaitk do you have an example how to test it, or that problem it is giving?

@jekuaitk

Copy link
Copy Markdown
Contributor

@jekuaitk do you have an example how to test it, or that problem it is giving?

Submitting https://test.os2forms.dk/da/form/jekua-issue-374 shows the issue we were running into after upgrading to Drupal 11 on a staging site.

TypeError: ParagonIE\HiddenString\HiddenString::__construct(): Argument #1 ($value) must be of type string, int given...

@stankut

stankut commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator Author

@jekuaitk i can see that the fix we made have been overwritten on test.os2forms.dk

i have added it back and the issue you raised is no longer there:
https://test.os2forms.dk/da/form/jekua-issue-374

@stankut
stankut merged commit 77cd59a into develop Nov 2, 2026
8 checks passed
@stankut
stankut deleted the f/computed-twig-encryption branch November 2, 2026 08:59
stankut added a commit that referenced this pull request Nov 3, 2026
…_digital_signature_security

* commit '100e15f20d3d26f5d9950134282b74bea48aa960': (42 commits)
  312: Set #parents before building handler configuration forms
  Computed twig  encryption fix (#380)
  #321 deleting SaveToFile handler (#382)
  Fixing autocomplete fields usage (#381)
  Add missing trailing comma
  Applied map display settings consistently
  Remove delete state from handlers and require php 8.3
  Preparing 6.1.0
  Bumped os2web_datalookup version
  Apply coding standards
  Ensure no attachments with export type html are signed
  Run handler conditions before adding signature validation text
  Upgrading Gin theme
  OS-320 SBSYS child elements integration (#365)
  Fixing translation setting page (#359)
  Synching develop with master changes (#364)
  Preparing release 6.0.0
  #355 OS-314 children select element '#address_protection_help_text' fix
  352: Code cleanup
  352: Updated CHANGELOG
  ...

# Conflicts:
#	modules/os2forms_digital_signature/src/Plugin/WebformHandler/DigitalSignatureWebformHandler.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kan ikke sende digital post efter installation af OS2Forms Encrypt

2 participants