Repository navigation
Conversation
…_digital_signature_security * commit '100e15f20d3d26f5d9950134282b74bea48aa960': (42 commits) 312: Set #parents before building handler configuration forms Computed twig encryption fix (#380) #321 deleting SaveToFile handler (#382) Fixing autocomplete fields usage (#381) Add missing trailing comma Applied map display settings consistently Remove delete state from handlers and require php 8.3 Preparing 6.1.0 Bumped os2web_datalookup version Apply coding standards Ensure no attachments with export type html are signed Run handler conditions before adding signature validation text Upgrading Gin theme OS-320 SBSYS child elements integration (#365) Fixing translation setting page (#359) Synching develop with master changes (#364) Preparing release 6.0.0 #355 OS-314 children select element '#address_protection_help_text' fix 352: Code cleanup 352: Updated CHANGELOG ... # Conflicts: # modules/os2forms_digital_signature/src/Plugin/WebformHandler/DigitalSignatureWebformHandler.php
Contributor
|
@MadNicGit vil I lave review på dette PR. Det er ikke et issue på dette PR af sikkerhedsmæssige årsager. Spørg evt. Gitte efter en mail jeg lige har sendt til Koordinationsgruppen. |
jekuaitk
reviewed
Nov 3, 2026
| $expectedFileUri = $file->getFileUri(); | ||
| // If $existingAttachment FID is present - we are replacing uploaded/managed | ||
| // file, otherwise, creating a new one. | ||
| $existingAttachment = $this->signingDocumentResolver->resolve($webformSubmission); |
Contributor
There was a problem hiding this comment.
Would it not be beneficial to resolve this as early as possible? Say, before downloading the signed file's content but after checking the hashes?
|
|
||
| /** @var \Drupal\webform\Plugin\WebformElementAttachmentInterface $elementPlugin */ | ||
| $elementPlugin = $this->elementManager->getElementInstance($element); | ||
| $attachments = $elementPlugin->getEmailAttachments($element, $webformSubmission); |
Contributor
There was a problem hiding this comment.
Am i right in saying that the resolve method is used in preSave() to render and get the actual content of the attachment file?
But then it is also used during signCallback() just for the purpose of finding the fid? Is it not possible to use a more light-weight method of finding the fid?
Comment on lines
+86
to
+91
| // SwiftMailer and Mime Mail consume filecontent rather than filepath. | ||
| if (($this->moduleHandler->moduleExists('swiftmailer') | ||
| || $this->moduleHandler->moduleExists('mimemail')) | ||
| && isset($attachment['filecontent'], $attachment['filepath'])) { | ||
| unset($attachment['filepath']); | ||
| } |
Contributor
There was a problem hiding this comment.
We don't use either of these modules. Do you?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.