Skip to content

docs: fix comment typos and grammar - #4768

Merged
KaloyanTanev merged 1 commit into
ObolNetwork:mainfrom
somasoil:fix/comment-typos
Oct 12, 2026
Merged

KaloyanTanev merged 1 commit into
ObolNetwork:mainfrom
somasoil:fix/comment-typos

Conversation

@somasoil

@somasoil somasoil commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes a few small comment issues (typos / grammar) found while reading the code:

  • p2p/receive_test.go: handler echoes the duty when the slot is even and returns
    nothing when the slot is odd. Comment said "Returns nothing is slot is odd" →
    "Returns nothing if slot is odd"; also "Echos" → "Echoes".
  • core/priority/prioritiser.go: "participate in a priority protocol instances"
    dropped the stray article → "participate in priority protocol instances".

No code behavior changed; comment-only edits to make docs match the actual logic.

category: docs
ticket: none

@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.56%. Comparing base (9eec102) to head (8fbb144).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4768      +/-   ##
==========================================
- Coverage   65.57%   65.56%   -0.01%     
==========================================
  Files         246      246              
  Lines       30117    30117              
==========================================
- Hits        19749    19747       -2     
- Misses      10367    10369       +2     
  Partials        1        1              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KaloyanTanev

Copy link
Copy Markdown
Collaborator

Hi @somasoil ! Can you sign your commit please?

- p2p/receive_test.go: "Echos" -> "Echoes"; "is slot is odd" -> "if slot is odd"
- core/priority/prioritiser.go: drop stray "a" before "priority protocol instances"
@sonarqubecloud

Copy link
Copy Markdown

@somasoil

somasoil commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor Author

Hi @somasoil ! Can you sign your commit please?

@KaloyanTanev Of course. Signed.

image

@KaloyanTanev
KaloyanTanev merged commit 3fafa2e into ObolNetwork:main Oct 12, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants