Repository navigation
docs(DiagramLayout): a Layout that only folds or hides places nothing - #11
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: jason.han <[email protected]>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
Author
|
The advisory
This PR merges cleanly onto the current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Layoutdoc comment now says whenxandyare needed. ALayoutthat binds onlycollapsedorshow…switches is legal and places nothing: it folds the element, or hides its compartments, where the view lays it out.x/yare needed only to place the element and go together: one coordinate alone is an error, and so is a size with no place.OpenSysML has accepted fold-only Layouts since Open-MBEE/OpenSysML#1254. This note uses the same rules as that PR and its documentation (
docs/project/diagram-layout-annotations.md, the "Limiting what a view draws" guide example).Only the comment changed: no declarations and no
engine-contract.jsonentries. Thecollapsedattribute has no doc comment of its own, so it was left as it is.Semver impact: PATCH (doc-comment change only).
Checks run locally:
./scripts/validate-libraries.sh(pinned pilot, 0 errors, 0 warnings),./scripts/check-engine-contract.sh --base origin/main(exit 0),./scripts/check-readme-table.sh.Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/3089cc5b6fb74efcba6bc4b8f739a409
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/3089cc5b6fb74efcba6bc4b8f739a409?variant=devin
Requested by: @HuiJun