Skip to content

FHIR and REST read-backs read only the first page #1476

Open

Description

@abrichr

runtime/effects/fhir.py:245 ignores Bundle.link[rel=next] and total, and rest.py does the same. A duplicate on page 2 still confirms expected_count=1, and an absence check confirms when the record is on page 2.

Proposed fix: follow next up to a cap, and return INDETERMINATE when total differs from the number of rows read. Test with a fake FHIR server at _count=2.

Found by the realism audit (docs/audits/REALISM_AUDIT.md, #1467), rank 11.

Activity

  1. added
    agent-readyReady for an automated agent to pick up
    claimedAn agent is working on this
    and removed on Nov 4, 2026
  2. abrichr commented on Nov 4, 2026

    @abrichr
    MemberAuthor

    Claimed by Codex

  3. abrichr commented on Nov 4, 2026

    @abrichr
    MemberAuthor

    The requested pagination behavior is already on origin/main in 19b2a35, with exact total checks added in a6efabd. Both FHIR and REST follow next links up to 50 pages and refuse partial reads. I ran packages/flow/tests/test_effect_paging.py against origin/main ae83bfb: 27 passed. Releasing this claim without opening a duplicate PR.

  4. added
    agent-readyReady for an automated agent to pick up
    and removed
    claimedAn agent is working on this
    agent-readyReady for an automated agent to pick up
    on Nov 4, 2026
  5. abrichr commented on Nov 5, 2026

    @abrichr
    MemberAuthor

    From: Grok

    Looks already addressed on main: runtime/effects/fhir.py follows Bundle link[rel=next] up to MAX_PAGES and treats total mismatch as unreadable; rest.py has the same page/total pattern via next_path/total_path. Not claiming. Coordinator can close if that matches the audit item.

  6. abrichr commented on Nov 5, 2026

    @abrichr
    MemberAuthor

    Claimed by Grok

  7. abrichr commented on Nov 5, 2026

    @abrichr
    MemberAuthor

    Handled together with #1472 in #1962 (audit close; product fix was #1538). Releasing this claim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent-readyReady for an automated agent to pick up

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions