Skip to content

Native Windows identity tests return mismatch instead of abstain #1842

Open

Description

@abrichr

Two existing identity tests fail on native Windows at main 9f026dad3bf70b464d62cf315ae1cc03396a6ad9: the OCR identity result is mismatch, while the tests require abstain.

Reproduce headlessly from packages/flow:

pytest -q tests/test_identity_homonym_8th.py::test_wrong_patient_does_not_verify_via_real_replayer_ocr_tier tests/test_identity_ocr_conservative_9th.py::test_numeric_100512_collapses_and_abstains_arial

No wrong-record verified result occurs in these failures. Diagnose the classification and make the existing assertions pass unchanged; keep the fail-closed behavior.

Environment: Windows 11 x64, Python 3.12.4, pytest 9.1.1, Pydantic 2.13.4, OpenCV 4.13.0.92, rapidocr-onnxruntime 1.4.4 and onnxruntime 1.24.3. Tests render synthetic fixtures without opening GUI windows. The same failures reproduce on #1743 at 43ff31046 and #1773 at 26b951f9a; they predate those PRs. Both broader identity runs pass on Linux (158 and 181 cases).

Validate the fix on native Windows and Linux. Do not loosen, remove or skip these tests.

Activity

  1. added
    agent-readyReady for an automated agent to pick up
    claimedAn agent is working on this
    on Nov 4, 2026
  2. abrichr commented on Nov 5, 2026

    @abrichr
    MemberAuthor

    Claimed by Grok

  3. abrichr commented on Nov 5, 2026

    @abrichr
    MemberAuthor

    From: Grok

    Cannot reproduce on Mac at 72b743e: both named tests passed (2 passed in 26.63s).

    pytest -q tests/test_identity_homonym_8th.py::test_wrong_patient_does_not_verify_via_real_replayer_ocr_tier tests/test_identity_ocr_conservative_9th.py::test_numeric_100512_collapses_and_abstains_arial
    

    Issue targets native Windows mismatch-vs-abstain. No Windows host available this session (lab 10.0.0.53 unreachable). Releasing claim so a Windows-capable agent can take it.

  4. added
    claimedAn agent is working on this
    and removed
    claimedAn agent is working on this
    on Nov 5, 2026
  5. abrichr commented on Nov 5, 2026

    @abrichr
    MemberAuthor

    Claimed by Grok

  6. abrichr commented on Nov 5, 2026

    @abrichr
    MemberAuthor

    Claimed by Grok — fix in #1961 (squash drops comma/period OCR noise so Windows glyph abstain holds). claimed removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent-readyReady for an automated agent to pick up

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions