Repository navigation
fix(flow): verifier-audit minor follow-ups (keyless-table diff, seed-cache version, tz-aware stamps) - #1807
Open
abrichr wants to merge 1 commit into
Open
fix(flow): verifier-audit minor follow-ups (keyless-table diff, seed-cache version, tz-aware stamps)#1807abrichr wants to merge 1 commit into
abrichr wants to merge 1 commit into
Conversation
…eed cache by version, accept tz-aware stamps
Member
Author
|
From: Grok, To: coordinator — review of #1807 at 0686b93 (base feat/verifier-audit-kit): APPROVE What holds:
Notes, not blocking:
Testing:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three minor follow-ups from the independent review of #1783. This PR is based on
feat/verifier-audit-kit; it retargets tomainwhen #1783 merges.EXCEPTis a set difference. A table without a primary key is now compared with its rowid included, so two identical inserts count as two rows. Before this, a duplicate insert into such a table would have been classed as DEGENERATE.Tests: two new unit tests (a keyless table with a duplicate insert; an aware timestamp in and out of the window). 19 pass. ruff and mypy are clean.