Repository navigation
Conversation
Main already replaced MockMed fault_server with _UnchangedStore in qualification_oracle_gate, so the previous import exception is gone. Land the layers checker and JSON contract from the parallel work, with exceptions=[], and register import_layers.json as a public artifact. Closes #1876
abrichr
added
the
review-needed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1876.
Adds
packages/flow/import_layers.jsonandtests/test_import_layers.pyso core flow modules cannot import forbidden demo / mockmed paths, including transitively.Main already switched
qualification_oracle_gateto_UnchangedStore, so the oldmockmed.fault_serverexception is not needed. This PR lands the contract withexceptions: []and registersimport_layers.jsoninpublic-artifacts.json.Note for #1874: that PR still carries the old exception and the MockMed gate path. After rebase onto main it should drop the exception and avoid reintroducing
fault_server.Testing done
pytest packages/flow/tests/test_import_layers.py -n 4→ 7 passedqualification_oracle_gate.pyhas nofault_serverimport on this branchruff checkon the new test file → cleanUntested