Repository navigation
Conversation
video_pre_callback grabbed the whole desktop to learn the stream size. That blocked for tens of seconds in a macOS VM guest and blew the writer startup budget. Prefer platform screen-dimension metadata (Quartz pixel mode on Darwin) and only fall back to a screenshot when metrics fail.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1883
Summary
Full-screen Recorder startup in a macOS VM guest spent ~28 s inside video_pre_callback on take_screenshot just to learn the stream size, past the writer budget. Window-scoped recording already skips that path.
video_pre_callback now sizes the stream with platform.get_screen_dimensions. On Darwin that probe reads Quartz CGDisplayModeGetPixelWidth/Height (matches a Retina grab) and does not read the framebuffer. get_display_pixel_ratio uses the same Quartz-first path. A screenshot remains only as a fallback when metrics are unavailable. get_monitor_dims stays logical for recording metadata.
Testing
Untested