Repository navigation
Conversation
Compiler marks "Create New Patient" reversible, but effective_step_risk re-runs classify_step_risk and the write-shaped label becomes irreversible again, so clinical-write demands a system-of-record effect on a click that saves nothing. Accept sealed opener evidence (explanation naming the confirm step plus a dialog postcondition) before the write-keyword branch.
abrichr
added
the
review-needed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1533
Summary
The compiler already marks an OpenEMR-style confirmation opener (for example "Create New Patient") as reversible, because the next Confirm click is the save. Policy then re-runs classify_step_risk, sees the write-shaped label, and treats the opener as irreversible again, so clinical-write demands a system-of-record effect and an idempotency key on a click that writes nothing.
This change accepts sealed confirmation-opener evidence in infer_step_risk before the write-keyword branch: the compiler explanation that names the confirm step, plus a dialog postcondition (text_present or no_duplicate_candidate, which empty-result mining already seals on the referral path). Explanation alone is not enough.
Testing
Untested