Repository navigation
Keep agent self-reports out of benchmark judge inputs - #1988
Merged
Merged
Conversation
Signed-off-by: abrichr <[email protected]>
Signed-off-by: abrichr <[email protected]>
Member
Author
Independent adversarial review: APPROVEReviewed head What I ran
Leak audit
Findings (none blocking)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1982
The benchmark judge now evaluates task intent, structured actions, screenshots and explicitly sourced observations without agent final answers or per-turn narration. The input boundary covers action scoring, batched and fallback screenshot analysis, rubric rescoring and outcome verification. Measured HTTP status remains transport evidence, and legitimate record text is preserved.
Validation on WSL: 12 offline fake-client tests passed; changed-file and package Ruff checks passed; package formatting passed; mypy passed for 593 source files with the same-checkout types package; release consistency and engine generality passed.
No model calls or benchmark rescoring were performed. Historical protocol and result files retain their bytes. Observation provenance remains the responsibility of the harness adapter; the tests verify that every constructed model message respects that boundary.