Repository navigation
Conversation
Signed-off-by: abrichr <[email protected]>
…into codex/generated-effect-1986 Signed-off-by: abrichr <[email protected]>
Signed-off-by: abrichr <[email protected]>
abrichr
added
the
review-needed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated save contracts can now bind task, before and after observations to typed predicates in the shared expression language. The effect profile adds immutable records, keyed collections and exact allowed-delta checks to the existing parser, type checker and evaluator, with one input/work budget across a model. The published text-transform manifest remains unchanged.
The shadow consumer checks independently supplied reader scope, freshness and source identities, preserves prior refutations, and returns its candidate separately from canonical state. Replay admission requires complete independently labelled history against matching model, language, schema, reader and source identities. Tests cover unintended changes, missing evidence, budget exhaustion and signed-receipt isolation.
Validation on WSL: 209 targeted tests passed; focused Ruff lint/format and safety-style mypy checks passed. Engine generality and release consistency checks also passed.
Depends on #1983.
Closes #1986.
No model-construction or real-app qualification study ran. The general-profile defects reported on #1983 remain its owner’s work; this effect profile excludes regex and fuzzy operators. This PR remains blocked on that dependency.