Skip to content

Revert "flow: scope Linux X11 recording to one window (#1966)" - #2001

Merged
abrichr merged 1 commit into
mainfrom
revert/1966-linux-window-record
Nov 5, 2026
Merged

abrichr merged 1 commit into
mainfrom
revert/1966-linux-window-record

Conversation

@abrichr

@abrichr abrichr commented Nov 5, 2026

Copy link
Copy Markdown
Member

Main's Packages build has been red since #1966 merged. The new flow native Linux (AT-SPI, Xvfb) window-record check fails on main with record exited early with 1 (run on 3edb309), and the PR's own CI didn't run that job. A red main blocks every merge. This reverts #1966 so main is green again; it can reland with the fix Codex is preparing. If the fix lands first, close this.

@abrichr

abrichr commented Nov 5, 2026 •

Copy link
Copy Markdown
Member Author

Independent adversarial review: APPROVE

Reviewed-Head: 3d7a443

An object-level comparison confirms that all eight changed paths, blob IDs and modes are the exact inverse of a23c2d8 (#1966), applied to parent 3edb309. The rollback restores rejection of Linux window-scoping flags before recording; it does not silently capture the desktop for a requested window.

The current head has no failing or pending checks: all three Flow unit shards, package lint, the package gate, source-boundary checks and Linux Capture/Xvfb checks passed. The native Linux job is skipped on this PR, so this is not a claim that the failing window-record probe passed. Parent main failed that probe in run 42116091469; the separate fix is not ready to land. No new local tests were run for this exact-revert review.

@abrichr
abrichr merged commit 75cdcb3 into main Nov 5, 2026
54 checks passed
@abrichr
abrichr deleted the revert/1966-linux-window-record branch November 5, 2026 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant