Repository navigation
Conversation
Signed-off-by: rherrell <[email protected]>
Signed-off-by: rherrell <[email protected]>
Signed-off-by: rherrell <[email protected]>
Signed-off-by: rherrell <[email protected]>
Signed-off-by: rherrell <[email protected]>
Signed-off-by: rherrell <[email protected]>
Signed-off-by: rherrell <[email protected]>
Signed-off-by: rherrell <[email protected]>
Signed-off-by: rherrell <[email protected]>
Signed-off-by: rherrell <[email protected]>
Signed-off-by: rherrell <[email protected]>
Signed-off-by: rherrell <[email protected]>
…end_FS.remove() Signed-off-by: rherrell <[email protected]>
…modules Signed-off-by: rherrell <[email protected]>
… issues events about all. Signed-off-by: rherrell <[email protected]>
Signed-off-by: rherrell <[email protected]>
Signed-off-by: rherrell <[email protected]>
Signed-off-by: rherrell <[email protected]>
Signed-off-by: rherrell <[email protected]>
Signed-off-by: rherrell <[email protected]>
Signed-off-by: rherrell <[email protected]>
…t() return values Signed-off-by: rherrell <[email protected]>
Collaborator
Author
|
I have fixed the pytest script to expect the new return values (a true dict {} ) from the internal handle_event() entry point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the mainstream Event Generation capabilities are now functional on this implementation. Features added:
The number of interactions between the core CRUD features and the Event Generation features make it very hard to adequately test the huge number of corner cases and combinations of uploaded objects, so be prepared to debug such when working with different uploaded objects.
The recent changes in return values from the internal calling points confuse the pytest suite, so some of the pytest tests need to be changed still. We can't pass the merge requirements yet, but we can start looking over the major changes in the core library and event handlers.