Repository navigation
Instrument presets: Orbitrap HCD, timsTOF and Ion Trap CID - #50
Closed
t0mdavid-m wants to merge 1 commit into
Closed
t0mdavid-m wants to merge 1 commit into
t0mdavid-m wants to merge 1 commit into
Conversation
Replace the High Res MS / Low Res MS presets, which only set the label-free Comet search, with three instrument presets that set the fragment bins, precursor tolerance and isotope errors for both the label-free and the TMT search. A test checks every Comet preset against the valid strings and fragment-bin checks of CometAdapter. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01D5Wo2FHPpi5a8X6GppNxEk
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Member
Author
|
Included in #52, which is merged. Closing. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: the Configure page offered "High Res MS" and "Low Res MS". They only set the label-free Comet search and did nothing in TMT mode. They also left the precursor tolerance as it was.
After: three instrument presets, Orbitrap HCD, timsTOF and Ion Trap CID, apply to both the label-free and the TMT search. Each sets the instrument type, fragment bins, precursor tolerance and isotope errors. This matches ProSE's instrument presets (S6 in the parity list).
Every instrument preset is a closed search. Applying one after the Open Search preset from #49 switches back to a ppm precursor tolerance.
How: the change is data only, in
presets.json. The newtests/test_comet_presets.pychecks every Comet preset against CometAdapter's own rules from release/3.5.0. It checks the valid strings for instrument, precursor units and isotope error. It also checks the fragment-bin rule that makes CometAdapter refuse to run without-force: high_res needs bins ≤ 0.1 Da and offset ≤ 0.1, and low_res needs bins ≥ 0.8 Da and offset > 0.2. This test will cover #49's Open and Closed Search presets once both branches are on main. The two branches merge without conflicts.Checked locally: pytest (127 passed) and pylint errors-only (only the 3 E0611 pyopenms imports already on main). I also clicked "Orbitrap HCD" on the Configure page and confirmed
params.jsonthen held the values above for bothCometAdapterandCometAdapter-TMT.Not in this PR: ProSE's user-saved presets and its "modified" hint. Both belong in the template's
preset_buttons, so they will go to OpenMS/streamlit-template first.🤖 Generated with Claude Code
https://claude.ai/code/session_01D5Wo2FHPpi5a8X6GppNxEk