Skip to content

Instrument presets: Orbitrap HCD, timsTOF and Ion Trap CID - #50

Closed
t0mdavid-m wants to merge 1 commit into
mainfrom
claude/parity-instrument-presets
Closed

t0mdavid-m wants to merge 1 commit into
mainfrom
claude/parity-instrument-presets

Conversation

@t0mdavid-m

@t0mdavid-m t0mdavid-m commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Before: the Configure page offered "High Res MS" and "Low Res MS". They only set the label-free Comet search and did nothing in TMT mode. They also left the precursor tolerance as it was.

After: three instrument presets, Orbitrap HCD, timsTOF and Ion Trap CID, apply to both the label-free and the TMT search. Each sets the instrument type, fragment bins, precursor tolerance and isotope errors. This matches ProSE's instrument presets (S6 in the parity list).

Preset instrument fragment tolerance (bin = 2×) bin offset precursor isotope error
Orbitrap HCD high_res 0.01 Da (0.02 Da bins, Comet's recommendation) 0.0 10 ppm 0/1
timsTOF high_res 0.025 Da (0.05 Da bins) 0.0 20 ppm 0/1
Ion Trap CID low_res 0.50025 Da (1.0005 Da bins) 0.4 20 ppm 0/1

Every instrument preset is a closed search. Applying one after the Open Search preset from #49 switches back to a ppm precursor tolerance.

How: the change is data only, in presets.json. The new tests/test_comet_presets.py checks every Comet preset against CometAdapter's own rules from release/3.5.0. It checks the valid strings for instrument, precursor units and isotope error. It also checks the fragment-bin rule that makes CometAdapter refuse to run without -force: high_res needs bins ≤ 0.1 Da and offset ≤ 0.1, and low_res needs bins ≥ 0.8 Da and offset > 0.2. This test will cover #49's Open and Closed Search presets once both branches are on main. The two branches merge without conflicts.

Checked locally: pytest (127 passed) and pylint errors-only (only the 3 E0611 pyopenms imports already on main). I also clicked "Orbitrap HCD" on the Configure page and confirmed params.json then held the values above for both CometAdapter and CometAdapter-TMT.

Not in this PR: ProSE's user-saved presets and its "modified" hint. Both belong in the template's preset_buttons, so they will go to OpenMS/streamlit-template first.

🤖 Generated with Claude Code

https://claude.ai/code/session_01D5Wo2FHPpi5a8X6GppNxEk

Replace the High Res MS / Low Res MS presets, which only set the
label-free Comet search, with three instrument presets that set the
fragment bins, precursor tolerance and isotope errors for both the
label-free and the TMT search. A test checks every Comet preset against
the valid strings and fragment-bin checks of CometAdapter.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01D5Wo2FHPpi5a8X6GppNxEk
@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4f10f2bc-893d-4cd1-b1e1-f67888153879
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Member Author

Included in #52, which is merged. Closing.


Generated by Claude Code

@t0mdavid-m t0mdavid-m closed this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants