Repository navigation
Conversation
get_private_dataset_files rebuilt the private config from disk_dict() and yaml.safe_dump, skipping migrate_to_schema and the codec. A protocol-0 peer then got canonical_name/version, which ProtocolCodecV0 strips on disk. Route that path through DatasetStorage.wire_bytes so wire bytes match a protocol-aware write, and test that protocol-0 wire bytes have no identity fields.
Dataset.private_config yaml-loaded the file and built PrivateDatasetConfigV1, skipping codec.read and migrate-to-latest. A V2 file would have come back as V1 forever. Read it through datasetStorage.read_private_config, and test that a V1 file upgrades when a throwaway V2 is registered.
pjwerneck
marked this pull request as ready for review
September 9, 2026 09:52
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two places still handled the serialization of
private_metadata.yamlmanually instead of going throughthe protocol codec, so both ignored the dataset's protocol version. Both now call the storage layer.
Changes
private_metadata.yamlis now serialized through the codec.Dataset.private_configgoes through storage.Testing
Asana task
https://app.asana.com/1/1185126988600652/project/1210542925864934/task/1216207166877921?focus=true