Repository navigation
fix csv file downloads - #30
Merged
Merged
Conversation
efiegel
force-pushed
the
fiegel/fix-csv-download
branch
from
October 22, 2026 21:20
086e05e to
a4b2206
Compare
dennis-chen-vanta
approved these changes
Oct 22, 2026
dennis-chen-vanta
left a comment
dennis-chen-vanta
left a comment
Contributor
There was a problem hiding this comment.
did you test that pdf/png still works with this change? LGTM otherwise.
Contributor
Author
yep! forgot to include the screenshot |
This was referenced Oct 26, 2026
dennis-chen-vanta
added a commit
that referenced
this pull request
Oct 26, 2026
…xfmt - One module per stage (spec, naming, options, help, groups, render), with main.ts running them in order. Values that were module-level globals (the group names, the groups with endpoints) are computed in buildGroups and passed in. - The renderer writes plain templates, and oxfmt lays them out using the repo's .oxfmtrc.json, replacing the hand-written line-width logic. - pluralize, indefinite, and change-case replace the hand-rolled singular/plural, a/an, and case helpers. Output is unchanged. - commandDescription is split by kind of command: actions, the group's own resources, resources under a collection, and resources under an item. - Downloads pass `parseAs: "blob"`. #30 added this to documents.ts by hand, so regenerating dropped it; `trust-centers download-resource-media` gets it too. - `pnpm generate:commands` runs scripts/codegen/main.ts. Apart from the header and parseAs, the generated commands match the previous generator's output after formatting. Co-Authored-By: Claude Opus 5.5 <[email protected]>
dennis-chen-vanta
added a commit
that referenced
this pull request
Oct 26, 2026
…xfmt - One module per stage (spec, naming, options, help, groups, render), with main.ts running them in order. Values that were module-level globals (the group names, the groups with endpoints) are computed in buildGroups and passed in. - The renderer writes plain templates, and oxfmt lays them out using the repo's .oxfmtrc.json, replacing the hand-written line-width logic. - pluralize, indefinite, and change-case replace the hand-rolled singular/plural, a/an, and case helpers. Output is unchanged. - commandDescription is split by kind of command: actions, the group's own resources, resources under a collection, and resources under an item. - Downloads pass `parseAs: "blob"`. #30 added this to documents.ts by hand, so regenerating dropped it; `trust-centers download-resource-media` gets it too. - `pnpm generate:commands` runs scripts/codegen/main.ts. Apart from the header and parseAs, the generated commands match the previous generator's output after formatting. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseAs: "blob"like trust center downloads