Repository navigation
Fix CTD tutorial variable column name - #422
Merged
ShaivanBhagat merged 2 commits intoNov 4, 2026
Merged
Conversation
ctd_build_2d_arrays was passed the display key (e.g. "oxygen") instead of the actual dataset column (ds_name, e.g. "o2"), so plotting any variable other than temperature/salinity/ph failed with a missing-column error. Look up VARIABLES[plot_variable]["ds_name"] so oxygen/nitrate/phosphate/ phytoplankton/primary_production/chlorophyll resolve to o2/no3/po4/phyc/ nppv/chl respectively.
for more information, see https://pre-commit.ci
erikvansebille
approved these changes
Nov 4, 2026
erikvansebille
left a comment
erikvansebille
left a comment
Member
There was a problem hiding this comment.
Good catch, thanks for updating @ShaivanBhagat! Can you merge this, or shall I do it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when running the ctd tutorial for biogeochemical variables,
ctd_build_2d_arraysruns into column not found issue.VARIABLES refers to the ds_names (
chl,no3,phyc...) but this is never called. Insteadctd_build_2d_arrayslooks for columns names such aschlorophyll,phytoplankton,nitratefromplot_variable. However, the parquet file has data in the former format.This fixes that the correct column names (biogeochemical) are called.