Repository navigation
Paginate standalone baseFields fetches - #312
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
generateApplicationFormJson still fetches only the default first 10 base fields.
Review effort: Lite
Findings: None
What changed in this PR
Updates standalone base-field retrieval and documentation to account for API pagination.
Changes:
- Requests the full collection in the optimization command.
- Updates curl examples with pagination parameters.
| File | Reviewed change |
|---|---|
standalone/pdc-process-base-fields |
Updates documented base-field requests. |
standalone/pdc-optimize-field-matching |
Retrieves all base fields; another consumer still uses an unpaginated request. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
See #311 which removes that old/broken script. |
GET /baseFields became paginated with a default _count of 10, so pdc-optimize-field-matching silently downloaded only the 10 newest base fields into data/baseFields.json for field-matching work, and the pdc-process-base-fields docstring examples invited the same mistake. Request the whole collection with _page=1 and _count=2147483647 (max int32), mirroring the copyBaseFields fix in the service repository, and fix the examples. GLM-5.3-Flash, an LLM supervised and prompted by @bickelj Issue PhilanthropyDataCommons/service#2619 Base Fields Sync description did not update
bickelj-agent
force-pushed
the
paginate-base-fields-fetches
branch
from
October 6, 2026 16:20
0811acb to
942b6b2
Compare
chriszs
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /baseFields became paginated with a default _count of 10, so the pdc-optimize-field-matching retrieve-base-fields command silently downloaded only the 10 newest base fields, and the pdc-process-base-fields docstring examples invited the same mistake. Request the whole collection with _page=1 and _count=2147483647 (max int32), mirroring the service repo copyBaseFields fix, and update the examples.
Issue PhilanthropyDataCommons/service#2619 Base Fields Sync description did not update
GLM-5.3-Flash, an LLM supervised and prompted by @bickelj