Repository navigation
Close review r2's follow-ups on the tool pilot's web arms - #236
Merged
Merged
Conversation
- v2-pilot meal wording names breakfast and lunch, as the reference's parameters do (state_universal_free_meals: "free breakfast and lunch to all students"; the copay parameter covers both meals). A breakfast-only program is not free meals here. - The d1263 rate-schedule line now rides on federal_refundable_credits too, since the refundable CTC depends on tax liability. - JSON-contract web arms count search-only turns toward the cap, and hear a cap message once it is reached. Before, the cap bound only tool-contract models. - An answer beside an unknown call gets the call's result. A repair waits while a server call is unfinished, because text there is a 400. - The audit keeps each OpenAI source object whole, counts entries that name the reference engine, and prints a caveat when a provider returns no result URLs (Gemini). - Tests pin litellm's block order when a deferred server result is moved next to its call. That case has thinking blocks and a nested (caller) search, as real Opus replies do. Two live probes with the board's settings ran four requests each, clean; their full request and response bodies are saved in the pilot record. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…s free Review r3 of #236 found three issues. - "v2-pilot" named two wordings, since the meal and refundable-credit lines changed after the v2 trial, so a resume could mix them. Each record and manifest now carries prompt_wording_sha256, a hash of every v2-pilot rewrite, and run refuses to resume across a change. Older v2-pilot records read as "unrecorded", so a resume into trial-v2b is refused. - A repair deferred behind an unfinished server call used up a repair round without telling the model what was missing. Now it uses none. - The no-result-URLs caveat is written to score.json's search_audit, not only printed. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
Author
|
Merging at 9249fc0.
This is internal pilot tooling only. No board condition, published number or release changes. 🤖 Generated with Claude Code |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #235 (merged as 069f6a5). This is internal pilot tooling only: no board condition, published number or release changes.
Review r2 of #235 (Opus 5.5) agreed at b8231bf and listed low-severity follow-ups. This PR closes them.
Wording (v2-pilot only)
state_universal_free_mealsis "free breakfast and lunch to all students", and the copay parameter covers both meals. Without that, a model could count a breakfast-only program. No reference among the 100 households changes. The review checked all seven free references and found none reduced-price.federal_refundable_credits, since the refundable CTC depends on tax liability.Harness
Audit
reference_engine_entriescounts searches and results that name PolicyEngine. These are not blocked or flagged, since a web+PE model may read the tool's docs.scoreprints a caveat when a provider returns no result URLs (Gemini).Evidence for Claude's server-tool paths (review r2, finding 1)
caller) search as real Opus replies have. It pins the block order.response_formatjson_object and the board's thinking configuration). Each ran four requests with no errors: a code-execution call deferred beside our tool, its result moved next to its call, then a nested search and two more calculations. Every request and response body is saved in~/reviews/policybench-tool-pilot-2026-10/web-arms/probes/. A third attempt timed out on its first request (600 s, an infrastructure failure) and is kept asmixed_probe_1_timeout.json.Tests
Review r3 (Opus 5.5) AGREED at 7210d03. Commit 9249fc0 then closes three of its low findings:
prompt_wording_sha256, a hash of every v2-pilot rewrite, andrunrefuses to resume across a wording change. The meal and refundable-credit lines changed after the v2 trial, so a resume into trial-v2b is now refused, not mixed.score.json, not only printed.Two things are left as they are. The web+PE notice still doesn't say that search-only turns share the 8-turn cap, because changing it would change the prompts the trial used. The run-level refusal has no test, because
runneeds the engine; the helpers behind it are tested. Tests: 141 passed. Review r4 covers this commit.Deferred (r1 finding 8). There is no cross-check of Gemini's search count: litellm's own count and grounding metadata are empty on Gemini's function-calling turns (live probe, 2026-10-20).
🤖 Generated with Claude Code