Repository navigation
Add an Effect List - #1205
Merged
Merged
Add an Effect List#1205
Conversation
Tellinq
force-pushed
the
feat/effect-list
branch
4 times, most recently
from
October 19, 2026 05:00
8f5ad3b to
6f98ae6
Compare
lunaynx
force-pushed
the
feat/effect-list
branch
from
October 19, 2026 12:47
6f98ae6 to
87480ab
Compare
lunaynx
requested changes
Oct 19, 2026
Tellinq
force-pushed
the
feat/effect-list
branch
from
October 19, 2026 21:50
87480ab to
3f03d9d
Compare
lunaynx
force-pushed
the
feat/effect-list
branch
from
October 20, 2026 01:59
3f03d9d to
83e66e5
Compare
lunaynx
approved these changes
Oct 20, 2026
lunaynx
force-pushed
the
feat/effect-list
branch
from
October 20, 2026 13:24
048e3db to
bb33ed6
Compare
Tellinq
force-pushed
the
feat/effect-list
branch
from
October 22, 2026 03:49
bb33ed6 to
f114300
Compare
Contributor
Author
|
I see this was approved but wasn't merged yet. Is there any remaining items needed from me before getting merged or is it needing to be approved by someone else first? |
Contributor
|
I can merge, I just usually wait for someone else on OneConfig changes just in case but it's not a hard rule. |
Contributor
Author
|
That's fair. To be honest in my orgs what I do is if I make changes in someone else's PR, I usually hold off on merging unless I'm an actual repo owner, but even then I usually try to have someone else review if I did something significant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Building off of #1200, this adds a Minecraft Effect list, useful for mods that wish to have prebuilt selection for effects instead of manually needing to build one from the generic tile picker.
Related Issue(s)
Same reasons as #1200
Checklist