Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The search bar in the HUD studio didn't use the theme font for typed text. Its
BasicTextFieldwas the only text field in the UI that didn't pass afontFamilyin itstextStyle. UnlikeText,BasicTextFielddoesn't pick up the theme font on its own, so the placeholder rendered correctly while the typed text fell back to the default font. The gap is most visible with the Minecraft themes, where the rest of the panel is in the pixel font.This PR adds
fontFamily = theme.typography.familyto theSearchBartext style inHudDesignStudio.kt, the same as every other text field. ThatSearchBaris used for both the HUD library search and the HUD settings search, so both are fixed.Tested on
26.3-fabricwith Minecraft Dark and PolyGlass Dark.Related Issue(s)
Closes #1179
Checklist