You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Medium Risk
Changes tenant-switch behavior for all filesystem I/O; incorrect flushing could break Storage or worsen isolation, though scope is narrow and covered by a new test.
Overview
Fixes tenant storage bleed in long-lived workers (Horizon/Octane): after disk root/url config is rewritten, Laravel’s FilesystemManager could still serve the previous disk adapter, so Storage kept using landlord storage/app instead of storage/tenant_{id}.
Adds flushFilesystemDisks(), which calls Storage::forgetDisk() for configured disks and drops the filesystem container binding, and invokes it from makeCurrent() (after tenant paths) and forgetCurrent() (after restoring landlord disk config and lang paths). forgetCurrent() also restores landlord filesystem disk roots/URLs before flushing, so switching back off a tenant picks up the correct paths.
A new unit test warms the landlord local disk, switches tenants, asserts paths point at tenant storage, then asserts forgetCurrent() restores the original landlord path.
Reviewed by Cursor Bugbot for commit 5b210e3. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix filesystem caching issue caught by nightly testbench
ci:deploy
ci:run-testbench
ci:skip-build