Skip to content

ci: observe Python 3.12 full-dependency resolution - #9140

Open
agourakis82 wants to merge 2 commits into
Project-MONAI:devfrom
agourakis82:9069-py312-full-dep-observability
Open

agourakis82 wants to merge 2 commits into
Project-MONAI:devfrom
agourakis82:9069-py312-full-dep-observability

Conversation

@agourakis82

Copy link
Copy Markdown

Related to #9069. This is a first CI observability step, not a compatibility fix.

Description

Add an informational Ubuntu/Python 3.12 job that installs .[all,testing], runs pip check, and uploads pip freeze as an artifact. The existing Python 3.10 full-dependency test matrix and package bounds are unchanged. The new job does not run the unit suite or establish Python 3.12 compatibility.

Validation

  • Parsed the updated workflow with yq.
  • git diff --check passed.
  • Did not run MONAI unit tests locally; this change is limited to CI configuration.

Types of changes

  • Non-breaking CI change.
  • New tests added.
  • Integration tests passed locally.
  • Quick tests passed locally.

Assisted by Codex.

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: Project-MONAI/MONAI/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5df92357-99da-49e2-a711-338cb01dc361
📥 Commits

Reviewing files that changed from the base of the PR and between 94fea07 and 362dee1.

📒 Files selected for processing: 1
  • .github/workflows/cicd_tests.yml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

When test_skip indicates that tests are required, a new Ubuntu job runs with Python 3.12. It installs the complete dependency set, removes ITK, and runs pip check. The job records the resolved packages and uploads them as an artifact, even if an earlier step fails. The job has a 90-minute timeout and continues on error.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 362de

The new Python 3.12 job provides a non-gating dependency-resolution snapshot when tests are required; it does not claim to establish Python 3.12 compatibility. No merge-blocking risk was identified.

Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Title check Passed The title clearly identifies the CI change: observing full-dependency resolution with Python 3.12.
Description check Passed The description explains the CI job, its scope, validation performed, and change type. It also identifies the related issue and clearly states that Python 3.12 compatibility is not established.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@agourakis82

Copy link
Copy Markdown
Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

@agourakis82
agourakis82 marked this pull request as ready for review September 29, 2026 18:16
Copilot AI balanced review requested due to automatic review settings September 29, 2026 18:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The isolated, non-blocking workflow job matches the stated observability scope and preserves existing CI behavior.

Review effort: Balanced
Findings: None

What changed in this PR

Adds a non-blocking Python 3.12 CI job to observe full dependency resolution without changing compatibility guarantees or existing matrices.

Changes:

  • Installs all testing dependencies and runs pip check.
  • Uploads the resolved environment from pip freeze.
File Description
.github/​workflows/​cicd_tests.yml Adds the informational Python 3.12 dependency-resolution job.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@agourakis82
agourakis82 force-pushed the 9069-py312-full-dep-observability branch from 42c5281 to e970953 Compare October 1, 2026 22:25
@agourakis82

Copy link
Copy Markdown
Author

Refreshed this branch against upstream dev at 9a6ac14 in b945eba, without conflicts. The observational workflow is byte-identical to the previous public head; the refresh does not modify existing jobs, matrices or gates.

Local validation was limited to Ruby/Psych workflow comparisons, bash syntax and Git whitespace/scope checks. Dependency resolution, MONAI tests and Actions were not run locally. Could a maintainer approve the workflow runs when available so the required jobs can execute?

Comment thread .github/workflows/cicd_tests.yml
Comment thread .github/workflows/cicd_tests.yml Outdated
Add an informational Ubuntu job that installs all optional and test dependencies on Python 3.12, checks the resolved environment, and uploads a version snapshot. Keep the existing Python 3.10 full-dependency matrix unchanged.

Assisted-by: OpenAI Codex
Signed-off-by: Demetrios Agourakis <[email protected]>
@agourakis82
agourakis82 force-pushed the 9069-py312-full-dep-observability branch from 362dee1 to 4043f3b Compare October 14, 2026 10:27

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants