Repository navigation
[Refactor] asap-executor has two compilers from PhysicalASAPDAG to operators #999
Description
Problem
asap-executor has two compilers from a PhysicalASAPDAG to runnable operators:
physical_planner::compile / compile_before (mod.rs:69) |
physical_planner::precompute::compile (precompute.rs:182, 688 lines) |
|
|---|---|---|
| Production callers | planner/src/installable.rs (install step) |
none; only executor/tests/precompute*.rs and integration-tests/tests/precompute_raw_samples.rs |
Raw-data Scan |
table slot bound by Source, with a derived window |
materialized-view slot bound by node id, no window |
| Row shape | the node's schema | its own schema with $population and $window_end columns (population_schema) |
So the same DAG can be lowered two ways, with different slot binding and row shapes. The planner and the runtime install only use the first. The second is maintained and tested on its own. Its behaviour can drift from the first without any production path noticing.
The target is one lowering, PhysicalDAG → operators, in the executor.
Found in a read-only audit at b318df5b.
Activity
zzylol commentedon Oct 28, 2026
Resolved by #1001: it deleted
physical_planner/precompute.rs(andcandidates.rs).mainnow has one lowering,physical_planner::compile, and theprecompute_*tests run through it. Checked at93c90aca.