Repository navigation
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mainfailscargo test --workspace --lockedat 825504e. #795's two merged-DDSketch-pane tests incrates/planner/tests/runtime_install.rswere written against the exhaustive search's candidate ids, but #792 (merged just before) made the default search number only the candidates it composes and keep only the first rejection of each cause:a_non_negative_gauges_merged_ddsketch_panes_carry_the_relative_bound_through_avg: expectsP5-m1, and the same plan is nowP3-m1;an_undeclared_gauges_merged_ddsketch_panes_get_no_relative_bound_through_avg: expectsP5-m1in the error, and the error now listsP1'sRawDataNotRetained.What
Test-only. The first test no longer asserts the selected id, which depends on how many candidates the search enumerates (
P3-m1today, and fewer with the next joint-search PRs). Its plan, answer and bound checks are unchanged. The second asserts the failure is "no valid candidate" with aRawDataNotRetainedrejection.How
The id assertion is dropped and the error assertion is updated. Nothing else changes.
Key code interfaces added / modified
None (tests only).
Before this PR
On main,
cargo test -p asap-planner --test runtime_install: 14 passed, 2 failed.After this PR
The same command: 16 passed.
Verification
cargo test --locked -p asap-planner --test runtime_installpasses. #797 (components) carries the same change.