Skip to content

test(planner): merged-DDSketch-pane tests read the default search's numbering (#792 x #795) - #800

Closed
zzylol wants to merge 1 commit into
mainfrom
fix/795-tests-default-search
Closed

zzylol wants to merge 1 commit into
mainfrom
fix/795-tests-default-search

Conversation

@zzylol

@zzylol zzylol commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Why

main fails cargo test --workspace --locked at 825504e. #795's two merged-DDSketch-pane tests in crates/planner/tests/runtime_install.rs were written against the exhaustive search's candidate ids, but #792 (merged just before) made the default search number only the candidates it composes and keep only the first rejection of each cause:

  • a_non_negative_gauges_merged_ddsketch_panes_carry_the_relative_bound_through_avg: expects P5-m1, and the same plan is now P3-m1;
  • an_undeclared_gauges_merged_ddsketch_panes_get_no_relative_bound_through_avg: expects P5-m1 in the error, and the error now lists P1's RawDataNotRetained.

What

Test-only. The first test no longer asserts the selected id, which depends on how many candidates the search enumerates (P3-m1 today, and fewer with the next joint-search PRs). Its plan, answer and bound checks are unchanged. The second asserts the failure is "no valid candidate" with a RawDataNotRetained rejection.

How

The id assertion is dropped and the error assertion is updated. Nothing else changes.

Key code interfaces added / modified

None (tests only).

Before this PR

On main, cargo test -p asap-planner --test runtime_install: 14 passed, 2 failed.

After this PR

The same command: 16 passed.

Verification

cargo test --locked -p asap-planner --test runtime_install passes. #797 (components) carries the same change.

…'s numbering

#795's tests were written against the exhaustive search's candidate
ids (P5-m1); with #792's default search the same plan is P3-m1, and a
failed selection lists the first rejection of each cause.
@zzylol zzylol added bug Something isn't working search Candidate-plan search space and algorithms testing Corpus, regression, differential, or benchmark tests and removed search Candidate-plan search space and algorithms labels Oct 21, 2026
@zzylol

zzylol commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #801, which fixed the same #792 x #795 test breakage on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working testing Corpus, regression, differential, or benchmark tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant