You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Switches the ASAPPlanner git deps (asap-types, asap-aware-mapping, asap-frontend-promql, asap-frontend-sql) from the pinned rev 029ff2fe to branch = "main" (lock now at 8b90f04c). The other git deps (asap_sketchlib, asap-precompute-rs) were already on main.
Planner main added DataType::{Date, Interval} and ScalarValue::Interval. The ClickHouse relational adapter and backfill reader now reject them as unsupported (interval table-population literals are rejected in TablePopulation::validate, alongside nulls). Workspace builds.
⚠️ Two control_plane tests fail with Planner main (both pass on origin/main); see the comment below.
@zzylol could you help with two control_plane tests that fail after bumping ASAPPlanner from 029ff2fe to main (8b90f04c)? Both pass on origin/main, and both look like Planner selection no longer choosing a summary.
panicked at control_plane/src/physical/compiler.rs:4752: post-ASAP selection: NoLegalCandidate
Fails on sum_over_time(m[1m]) / count_over_time(m[1m]). select_summary_with_evidence (planner_selection.rs:455) calls SketchAlgorithmStrategy::with_models_and_evidence(...).replacements(&TargetSubDAG::new(&root)) with EpsilonDelta { 0.01, 0.01 }, DefaultAccuracyModel, EqualSplitAllocator, and ControlPlaneCostModel; it now returns zero replacements.
panicked at control_plane/src/physical/compiler.rs:4145: no warm candidate for quantile_over_time(0.9,data[5m])/quantile_over_time(0.5,data[5m]): []
Every candidate compiles, but none has a materialization, i.e. search_workload_with_targets + global_selection (planner_selection.rs:377, strategies at :348) appears to pick KeepPreAsap at EpsilonDelta { 0.01, 0.01 }.
Both involve a binary op over two range-vector functions, so they may share a cause. Is this an intended Planner behavior change, or a regression?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the ASAPPlanner git deps (
asap-types,asap-aware-mapping,asap-frontend-promql,asap-frontend-sql) from the pinned rev029ff2fetobranch = "main"(lock now at8b90f04c). The other git deps (asap_sketchlib,asap-precompute-rs) were already onmain.Planner main added
DataType::{Date, Interval}andScalarValue::Interval. The ClickHouse relational adapter and backfill reader now reject them as unsupported (interval table-population literals are rejected inTablePopulation::validate, alongside nulls). Workspace builds.control_planetests fail with Planner main (both pass onorigin/main); see the comment below.🤖 Generated with Claude Code