Skip to content

fix(deps): pin ASAPPlanner 7565c47e; depend on asap-planner's PromQL frontend only - #843

Merged
zzylol merged 1 commit into
mainfrom
fix/repin-planner-780
Oct 21, 2026
Merged

zzylol merged 1 commit into
mainfrom
fix/repin-planner-780

Conversation

@zzylol

@zzylol zzylol commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Base: main. Unblocks the comparison run's quantile queries.

Why

The first comparison run showed the backend refusing every quantile query: at the pinned ASAPPlanner ecea897f, KLL and DDSketch had no accuracy guarantee when raw_data_retained=false. ASAPPlanner #780 fixes this, so the backend needs a new pin.

What

How

The rev and the asap-planner features change in Cargo.toml, followed by cargo update -p asap-planner -p asap-executor. No backend source changes: the API the backend uses is the same at 7565c47e.

Before this PR

Pinned to ecea897f. Without raw data, quantile queries got no sketch guarantee and were refused, and the build included DataFusion.

After this PR

Pinned to 7565c47e, which includes the sign and non-negative-gauge fixes; PromQL frontend only.

A workload benefits from #780 only when it declares its gauges in data_workload.sources, with "metric_type": "gauge" and "values_non_negative": true. The harness workloads need that.

Verification

  • cargo test --workspace --locked passes, including the e2e examples.
  • python3 -m unittest discover -s scripts/ci: the sync-script tests pass, including the real-manifest test with the features key.
  • Cargo.lock has no datafusion entry.

…frontend only

Pin both Planner crates to ASAPPlanner 7565c47e, which brings:
- #780: a gauge declared non-negative (SourceFacts::values_non_negative)
  lets a per-series quantile sketch's relative error carry through sum and
  avg, and a quantile estimate carries its samples' sign;
- #782: the SQL and MetricsQL frontends are optional features.

asap-planner is now used with default-features = false, features =
["promql"], so DataFusion and the SQL and MetricsQL frontends drop out of
the build (Cargo.lock: -1,847 lines). The sync script accepts a pin
followed by other keys, such as features.

Not yet: ASAPPlanner #787 (StoredOutput.coverage and inputs replace pane);
that adaptation comes next.
@zzylol zzylol added bug Something isn't working integration: ASAPPlanner ASAPPlanner API, IR, candidate, and selected-plan integration labels Oct 21, 2026
@zzylol
zzylol merged commit c1ec0c2 into main Oct 21, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working integration: ASAPPlanner ASAPPlanner API, IR, candidate, and selected-plan integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant