Repository navigation
fix(deps): pin ASAPPlanner 7565c47e; depend on asap-planner's PromQL frontend only - #843
Merged
Merged
Conversation
…frontend only Pin both Planner crates to ASAPPlanner 7565c47e, which brings: - #780: a gauge declared non-negative (SourceFacts::values_non_negative) lets a per-series quantile sketch's relative error carry through sum and avg, and a quantile estimate carries its samples' sign; - #782: the SQL and MetricsQL frontends are optional features. asap-planner is now used with default-features = false, features = ["promql"], so DataFusion and the SQL and MetricsQL frontends drop out of the build (Cargo.lock: -1,847 lines). The sync script accepts a pin followed by other keys, such as features. Not yet: ASAPPlanner #787 (StoredOutput.coverage and inputs replace pane); that adaptation comes next.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base: main. Unblocks the comparison run's quantile queries.
Why
The first comparison run showed the backend refusing every quantile query: at the pinned ASAPPlanner
ecea897f, KLL and DDSketch had no accuracy guarantee whenraw_data_retained=false. ASAPPlanner #780 fixes this, so the backend needs a new pin.What
7565c47e. Compared withecea897f, that adds:rate,increaseandirateof a declared counter become non-negative Count-Min weights;SourceFacts::values_non_negative) lets a per-series quantile sketch's relative error carry throughsumandavg, and a quantile estimate carries the sign of its samples.asap-planneris now a dependency withdefault-features = false, features = ["promql"]. DataFusion and the SQL and MetricsQL frontends drop out of the build, and Cargo.lock shrinks by about 1,850 lines.scripts/sync-asapplanner-main.shnow accepts a pin followed by other keys, such asfeatures.StoredOutput.coverageandinputsreplacepane; the plan's definition id) is not included. Adapting the SDS to it needs the plan's full selection in the summary-instance key, because outputs with the same definition but different label constraints share one definition id. That comes in the next PR.How
The
revand theasap-plannerfeatures change inCargo.toml, followed bycargo update -p asap-planner -p asap-executor. No backend source changes: the API the backend uses is the same at7565c47e.Before this PR
Pinned to
ecea897f. Without raw data, quantile queries got no sketch guarantee and were refused, and the build included DataFusion.After this PR
Pinned to
7565c47e, which includes the sign and non-negative-gauge fixes; PromQL frontend only.A workload benefits from #780 only when it declares its gauges in
data_workload.sources, with"metric_type": "gauge"and"values_non_negative": true. The harness workloads need that.Verification
cargo test --workspace --lockedpasses, including the e2e examples.python3 -m unittest discover -s scripts/ci: the sync-script tests pass, including the real-manifest test with thefeatureskey.Cargo.lockhas nodatafusionentry.