Conversation
HTML comments are stored as raw blocks. When picture was treated as inline, a comment inside a line-started picture split the element across paragraphs and produced invalid HTML. picture belongs with video and other media tags whose contents Markdown should not rewrite. An inline picture in mid-paragraph is unchanged. Fixes Python-Markdown#1643.
Collaborator
|
|
Member
|
As the HTML spec clearly identifies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A line-started
<picture>with an HTML comment inside it was split across paragraphs, becausepicturewas treated as inline HTML while comments are raw blocks. That produced invalid markup such as<p><picture>…<!-- … --></p><p><source>…</picture></p>.Treat
pictureas a block-level HTML element, matchingvideoand other media tags whose contents Markdown should not rewrite. A<picture>that appears mid-paragraph remains inline.Fixes #1643.
AI Assistance Disclosure
AI tools (Cursor) were used to locate the issue, draft the change, and write tests. I reviewed the parser behavior, confirmed the test fails on
masterand passes after the change, and ran the unit suite.Checklist