docs(site): add a favicon so link cards show a thumbnail - #89
Merged
Merged
Conversation
Chat apps such as DingTalk render the site icon as the link card thumbnail; the site emitted no favicon at all, so cards showed an empty slot while sibling sites on the same domain showed theirs. Co-authored-by: QoderAI (Qwen 3.8 Max) <[email protected]>
A favicon has no surrounding text color for currentColor to inherit, so the synced icon now carries a prefers-color-scheme block: black mark on light browser chrome, white on dark, mirroring how the plugin icon picks up the vault theme. Co-authored-by: QoderAI (Qwen 3.8 Max) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/assets/qoder-icon.svginto the site asstatic/img/favicon.svg, same pipeline as the other shared assets.currentColoris replaced by classes plus aprefers-color-schemeblock (black mark on light browser chrome, white on dark). A favicon has no surrounding text color to inherit, so plaincurrentColorwould pin it to black and vanish on dark tabs; this mirrors how the plugin icon follows the vault theme.<link rel="icon" type="image/svg+xml" href="/Qoderian/img/favicon.svg">viaheadTags.themeConfig.faviconwas tried first and produced no output in the built HTML;headTagsmatches how the sibling site does it. The href is absolute becauseheadTagshrefs are emitted verbatim and a relative one 404s under/docs/.Test plan
npm run buildsucceeds forenandzh-Hansimg/favicon.svgcarries the media query and nocurrentColor