Repository navigation
Try again to get things working for all rules on 1.10 - #579
Merged
Merged
Conversation
kshyatt
marked this pull request as ready for review
October 14, 2026 16:50
lkdvos
reviewed
Oct 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 57 files with indirect coverage changes 🚀 New features to boost your workflow:
|
lkdvos
reviewed
Oct 26, 2026
lkdvos
approved these changes
Oct 29, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It might be worth changing the
copy=trueto depend on whetherApreally will aliasAinpermute. For other cases I'd like to get rid of these version checks and make sure things really do work on all versions we support.