Repository navigation
Conversation
johnahull
force-pushed
the
feat/gim-artifact-resolution
branch
from
October 27, 2026 16:23
10e2120 to
c562551
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The AMD GIM driver is distributed through release artifacts whose layout differs between older releases and current releases. The operator's GIM Dockerfile templates previously constructed the download URL and package names from the driver version alone. As a result, a KMM build for
9.3.0.Kcould not resolve the correct GIM package without manual host-side preparation.This blocks the intended DeviceConfig flow for AMD VF passthrough: configure the GIM version in the operator, build the module image with KMM, and expose the resulting VFs to workloads.
What this changes
8.4.1.Kthrough9.3.0.Kuse direct release tags matching the version.8.1.0.Kretain themainline%2F<version>tag layout.-0revision for older releases;9.3.0.Kuses the published package without that revision.gim-dkms_<version>_all.deb.Compatibility
The legacy artifact mapping remains unchanged for older GIM versions. The new build arguments are added only to VF-passthrough KMM builds; container-driver and PF-passthrough flows are not changed by the artifact resolver. The generic selector and custom-VFIO-ID behavior is intentionally covered by separate PR #675.
Testing
GOTOOLCHAIN=auto go test ./api/... ./cmd/... ./internal/... ./tools/build/copyrightGOTOOLCHAIN=auto go vet ./api/... ./cmd/... ./internal/... ./tools/build/copyrightgit diff --check8.4.1.Kand9.2.0.K, plus legacy8.1.0.Kand current9.3.0.K.9.3.0.KKMM build arguments. The build downloaded and installedgim-dkms_9.3.0.K_all.deb, compiled DKMS for kernel6.8.0-139-generic, and producedgim.koin the resulting image.Out of scope
-efix in PR fix(workermgr): correct vfio unbind path test #673.Live KMM reconciliation on OpenShift and VFIO validation on physical AMD hardware remain to be performed.