Skip to content

R CMD check --as-cran upkeep - #7904

Open
aitap wants to merge 7 commits into
masterfrom
R-cmd-check--as-cran
Open

aitap wants to merge 7 commits into
masterfrom
R-cmd-check--as-cran

Conversation

@aitap

@aitap aitap commented Sep 29, 2026 •

Copy link
Copy Markdown
Member
  • Authors@R is now required to only have calls to person and c. We could also prepare a patch for R to allow NULL in the c(...) call once again.
  • Normal link drift, including https://www.rdocumentation.org returning 502
  • NEWS.md had one heading with a wrong level, which confused news()
  • New check for \usage line length (so that the line fits into the PDF page)
  • The last but not the least: --as-cran now includes _R_CHECK_CODOC_FUNCTIONS_MISSING_FROM_USAGES_=NA, which enables a test in tools::codoc() requiring a \usage{} entry for every exported object. For now, this is not even a NOTE (only INFO) and shouldn't affect CRAN submission. These were easy to add for the melt and dcast generics, but not for := or let. We could:
    • Ignore them for now. It works for rlang...
    • Add usage entries for `:=`(...) and let(...) saying something like "please don't do this". This would also force us to document the ... argument.
    • Change the formals of := to (LHS, RHS) and add usage entries for LHS := RHS and let(...) (with a comment that this only works inside a data.table operation). Document ... as a sequence of tagged LHS = RHS pairs. This isn't entirely right because := also accepts a sequence of tagged arguments.

R CMD check only allows calls to person(), c(person(), ...).
Found the following (possibly) invalid URLs:
  URL: https://mac.r-project.org/openmp (moved to https://mac.r-project.org/openmp/)
    From: NEWS.md
    Status: 301
    Message: Moved Permanently
Found the following (possibly) invalid URLs:
  URL: https://www.rdocumentation.org/packages/data.table/functions/setkey
    From: inst/doc/datatable-faq.html
    Status: 502
    Message: Bad Gateway
Found the following (possibly) invalid URLs:
  URL: https://www.rdocumentation.org/trends
    From: README.md
    Status: 502
    Message: Bad Gateway
* checking package subdirectories ... NOTE
Problems with news in ‘NEWS.md’:
  Cannot extract version info from the following section titles:
    NOTES
* checking Rd line widths ... NOTE
Rd file 'nafill.Rd':
  \usage lines wider than 90 characters:
     setnafill(x, type=c("const", "locf", "nocb"), fill=NA, nan=NA, cols=seq_along(x),
limit=Inf)
R CMD check now requires \usage{} entries for all exported functions:

Exported functions without usage information:
  melt dcast
@tdhock

tdhock commented Oct 2, 2026

Copy link
Copy Markdown
Member

thanks Ivan.
Sounds like this is the best choice (least work)
Add usage entries for :=(...) and let(...) saying something like "please don't do this". This would also force us to document the ... argument.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants