Skip to content

Refresh trigger menu with optional preview and compact pins - #162

Open
mdroidian wants to merge 8 commits into
mainfrom
codex/jj-menu-refresh
Open

mdroidian wants to merge 8 commits into
mainfrom
codex/jj-menu-refresh

Conversation

@mdroidian

Copy link
Copy Markdown
Collaborator

The trigger menu now supports inspecting and pinning workflows while keeping the existing trigger, fuzzy search, keyboard navigation, and execution path.

  • Right/Left shows or hides a template preview without executing commands or prompts.
  • Compact pins are remembered in extension settings and promoted in the unfiltered menu; fuzzy search ranking and the ten-result limit stay intact.
  • A native-style footer replaces the header. Shift+Enter opens a custom workflow's source in the right sidebar without running it. Built-in definitions can be previewed; their Source action is disabled because they have no graph block.
  • The picker fits small viewports, scrolls keyboard selections into view, and dismisses safely when Roam replaces its triggering editor.

Validation: 15 repository tests passed, a dry build completed with zero errors, and 14 live Roam Playwright checks passed, including source opening, pin persistence through menu reopen, keyboard/pointer execution, empty results, and 375×600 / 375×420 layouts. Independent read-only review is clean after fixing viewport overflow and selection visibility.

TypeScript still reports 10 existing diagnostics versus 11 on the base, with none in changed files. Full-page pin persistence through developer-extension re-registration is inconclusive because the temporary loader can replace the settings identity. Human acceptance remains pending.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T08:16:22.797175Z e7c12d4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant