Repository navigation
Replace ref-array-di and ref-struct-di dependencies with local copies - #1635
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The unchanged adapter sources, import updates, dependency changes, and cache invalidation are consistent, with regression coverage and no unresolved findings.
0 open findings
What changed in this PR
Vendors the project-maintained array and struct adapters alongside local ref-napi, replacing their npm dependencies without changing adapter behavior.
Changes:
- Adds adapter sources, licenses, and CommonJS package boundaries.
- Updates imports and generator version to invalidate cached interfaces.
- Adds compatibility tests and documents vendoring maintenance.
| File | Description |
|---|---|
| third_party/ref-struct-di/package.json | Defines the struct adapter’s CommonJS boundary. |
| third_party/ref-struct-di/LICENSE | Preserves the MIT license. |
| third_party/ref-struct-di/lib/struct.js | Vendors the struct adapter. |
| third_party/ref-array-di/package.json | Defines the array adapter’s CommonJS boundary. |
| third_party/ref-array-di/LICENSE | Preserves the MIT license. |
| third_party/ref-array-di/lib/array.js | Vendors the array adapter. |
| third_party/README.md | Documents provenance and maintenance. |
| test/test-ref-types.js | Covers adapter behavior and pointer compatibility. |
| test/package/test-package.js | Checks packaged files and cache regeneration. |
| test/package/consumer.mjs | Verifies installed vendored adapters resolve. |
| rosidl_gen/templates/message-template.cjs | Generates imports for local adapters. |
| rosidl_gen/primitive_types.cjs | Uses the local struct adapter. |
| rosidl_gen/generator.json | Bumps the cache-invalidation version. |
| package.json | Replaces scoped adapters with array-index. |
| docs/BUILDING.md | Explains packaging and regeneration changes. |
| .prettierignore | Preserves upstream adapter formatting. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
minggangw
force-pushed
the
integrate-dependency
branch
from
October 16, 2026 06:40
89c8120 to
3a93bcc
Compare
ref-array-di and ref-struct-di dependencies with local copies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rclnodejs-only adapters so their development, testing, and releases can be coordinated without separate package publication steps.@rclnodejs/[email protected]and@rclnodejs/[email protected]underthird_party/, preserving their production JavaScript and MIT licenses byte-for-byte.ref-napiimplementation, includingPointerBuffersupport.array-indexdirectly.rclnodejsreleases.PointerBuffer-backed access.Fix: #1636