Skip to content

Replace rimraf cleanup and remove the redundant tree-kill declaration - #1638

Merged
minggangw merged 1 commit into
RobotWebTools:developfrom
minggangw:fix-1637
Oct 16, 2026
Merged

minggangw merged 1 commit into
RobotWebTools:developfrom
minggangw:fix-1637

Conversation

@minggangw

@minggangw minggangw commented Oct 16, 2026 •

Copy link
Copy Markdown
Member
  • Replace npx rimraf in npm run clean with Node.js fs.rmSync, preserving node-gyp clean and avoiding cleanup-specific package downloads.
  • Remove generated interfaces recursively, tolerate missing output directories, and retry supported transient errors up to three times while preserving failure propagation.
  • Remove the root rimraf development dependency.
  • Remove the unused direct tree-kill declaration; it remains a transitive dependency of tsdown.
  • Remove the rimraf import and obsolete Node 10 cleanup branches from the CLI installation tests, retaining the existing fs.rmSync behavior.

Fix: #1637

Copilot AI balanced review requested due to automatic review settings October 16, 2026 07:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused changes preserve cleanup behavior on supported runtimes, with no blocking issues identified.

0 open findings

What changed in this PR

Simplifies cleanup by using Node.js filesystem APIs and removing redundant direct dependencies.

Changes:

  • Replaces npx rimraf with recursive fs.rmSync, allowing missing output and retrying transient errors while preserving failure propagation.
  • Removes direct rimraf and tree-kill dependencies and obsolete Node 10 test cleanup branches.
File Description
test/​test-message-generation-bin.js Removes the rimraf import and uses existing fs.rmSync cleanup unconditionally.
package.json Updates the clean command and removes redundant dependencies.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 91.148%. remained the same — minggangw:fix-1637 into RobotWebTools:develop

@minggangw
minggangw merged commit 899e861 into RobotWebTools:develop Oct 16, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace rimraf cleanup and remove the redundant tree-kill declaration

3 participants