Repository navigation
Replace rimraf cleanup and remove the redundant tree-kill declaration - #1638
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes preserve cleanup behavior on supported runtimes, with no blocking issues identified.
0 open findings
What changed in this PR
Simplifies cleanup by using Node.js filesystem APIs and removing redundant direct dependencies.
Changes:
- Replaces
npx rimrafwith recursivefs.rmSync, allowing missing output and retrying transient errors while preserving failure propagation. - Removes direct
rimrafandtree-killdependencies and obsolete Node 10 test cleanup branches.
| File | Description |
|---|---|
| test/test-message-generation-bin.js | Removes the rimraf import and uses existing fs.rmSync cleanup unconditionally. |
| package.json | Updates the clean command and removes redundant dependencies. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npx rimrafinnpm run cleanwith Node.jsfs.rmSync, preservingnode-gyp cleanand avoiding cleanup-specific package downloads.rimrafdevelopment dependency.tree-killdeclaration; it remains a transitive dependency oftsdown.rimrafimport and obsolete Node 10 cleanup branches from the CLI installation tests, retaining the existingfs.rmSyncbehavior.Fix: #1637