Repository navigation
Remove obsolete Node.js compatibility guards - #1640
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The narrow test cleanup matches the supported Node.js minimum and has no identified blocking issues.
0 open findings
What changed in this PR
Removes obsolete test compatibility guards to align with the Node.js 20.20.2 minimum.
Changes:
- Removes version and
AbortControlleravailability checks. - Deletes outdated comments without changing test assertions or production behavior.
| File | Description |
|---|---|
| test/test-client.js | Removes the manual-abort availability guard and polyfill comment. |
| test/test-async-client.js | Removes the older-Node.js timeout skip and explanatory comments. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
coverage: 91.148%. remained the same — minggangw:fix-1639 into RobotWebTools:develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
18.20skip condition from the zero-timeout test.AbortControlleravailability check from the manual-abort test.20.20.2minimum.Fix: #1639